Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@bdero
Copy link
Member

@bdero bdero commented Sep 24, 2024

Resolves flutter/flutter#155636.

(Extends test in #55409)

@bdero bdero requested a review from chinmaygarde September 24, 2024 23:51
@bdero bdero self-assigned this Sep 24, 2024
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #55413 at sha 58eb6f2

@bdero bdero force-pushed the bdero/fluttergpu-windingorder branch from 58eb6f2 to d584231 Compare September 25, 2024 00:53
@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2024
@auto-submit auto-submit bot merged commit ed4c34a into flutter:main Oct 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 5, 2024
…156266)

flutter/engine@92b5b31...6d6bc39

2024-10-05 [email protected] Honor blur tile mode in BackdropFilter widget on Skia backend (flutter/engine#55640)
2024-10-05 [email protected] [Impeller] remove aiks color_filter and image_filter types. (flutter/engine#55654)
2024-10-05 [email protected] Roll Dart SDK from c1c971fd1b94 to 9aa80e32947d (1 revision) (flutter/engine#55673)
2024-10-05 [email protected] [Flutter GPU] Add WindingOrder. (flutter/engine#55413)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App flutter-gpu will affect goldens

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Flutter GPU] Add CullMode & WindingOrder.

2 participants