This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] one aiks context per app. #55393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
added 4 commits
September 24, 2024 10:13
gaaclarke
reviewed
Sep 26, 2024
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
This seems to make avoiding making a content context easier but it doesn't stop someone from doing it, right?
Shouldn't we be doing something like making the AiksContext constructor private (with friend access to the one spot we want to make them)? Or having a debug runtime check to make sure we don't make AiksContexts?
Contributor
Author
|
Who do we need to stop from doing it? its our own internal API. |
Member
The linked issue doesn't mention under what pretenses we were creating the extra content context. If it was our only option this should be fine, if we were erroneously doing it we'd need something like I mentioned with visibility changes and/or runtime checks. The wording of the issue makes it sound like we were making an error and we need to "ensure" we don't do it: "Today, it is easy to create context on demand and there are are few API guardrails that prevent one from being created." |
Contributor
Author
|
They're just expensive to create, and there is no need to make more than one. IMO this was just a plumbng problem. |
Contributor
Author
|
FYI @chinmaygarde PTAL |
chinmaygarde
approved these changes
Oct 3, 2024
jonahwilliams
added
the
autosubmit
matanlurey
added
the
revert
Contributor
|
Reason for revert: Postsubmit turned red (clang tidy and build). |
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
This reverts commit 7fbdef0.
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Oct 3, 2024
Reverts: #55393 Initiated by: matanlurey Reason for reverting: Postsubmit turned red (clang tidy and build). Original PR Author: jonahwilliams Reviewed By: {chinmaygarde} This change reverts the following previous change: Hoist the content context up to the ios_surface so that overlay layers don't recreate a bunch of expensive machinery. Fixes flutter/flutter#154836
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 3, 2024
…156174) flutter/engine@de1762d...20369c5 2024-10-03 [email protected] [Impeller] A text layout and shaping API for the standalone library. (flutter/engine#55598) 2024-10-03 [email protected] Refactor `et run` (and friends). (flutter/engine#55537) 2024-10-03 [email protected] [Impeller] Do not cull in TextFrameDispatcher::drawDisplayList if the transform has perspective (flutter/engine#55602) 2024-10-03 [email protected] iOS: Fix IOSSurfaceNoopTest (flutter/engine#55621) 2024-10-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] one aiks context per app. (#55393)" (flutter/engine#55625) 2024-10-03 [email protected] Roll Fuchsia Linux SDK from YKvfbpZ38daiwJ7H0... to TnSpLq0S9XT2rHGl1... (flutter/engine#55622) 2024-10-03 [email protected] [Impeller] one aiks context per app. (flutter/engine#55393) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from YKvfbpZ38dai to TnSpLq0S9XT2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Hoist the content context up to the ios_surface so that overlay layers don't recreate a bunch of expensive machinery. Fixes flutter#154836
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…er/engine#55625) Reverts: flutter/engine#55393 Initiated by: matanlurey Reason for reverting: Postsubmit turned red (clang tidy and build). Original PR Author: jonahwilliams Reviewed By: {chinmaygarde} This change reverts the following previous change: Hoist the content context up to the ios_surface so that overlay layers don't recreate a bunch of expensive machinery. Fixes flutter#154836
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist the content context up to the ios_surface so that overlay layers don't recreate a bunch of expensive machinery.
Fixes flutter/flutter#154836