Fixed solid blur style math #55194
Fixed solid blur style math #55194
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
I have this setup as a non-draft to see golden diffs. I'm surprised our existing goldens didn't catch this. Maybe they do but we overlooked them. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Hmm weird, the reproduction code looks right, but these golden tests look wrong. |
gaaclarke
force-pushed
the
inner-outer-fix-ctm
branch
from
d4e7f21 to
220b473
Compare
|
Golden file changes are available for triage from new commit, Click here to view. |
gaaclarke
changed the title
|
Golden file changes are available for triage from new commit, Click here to view. |
gaaclarke
added
the
autosubmit
…155329) flutter/engine@311ba97...4f2d866 2024-09-17 [email protected] Roll Skia from b5cc234f229d to 86abf2391374 (1 revision) (flutter/engine#55269) 2024-09-17 [email protected] Roll Dart SDK from 84fac36df65a to 50f697183f25 (3 revisions) (flutter/engine#55268) 2024-09-17 [email protected] [Flutter GPU] Remove the redundant smoketest. (flutter/engine#55267) 2024-09-17 [email protected] Fixed solid blur style math (flutter/engine#55194) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
fixes flutter/flutter#155075
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.