Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey requested a review from jtmcdole September 12, 2024 22:23
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey merged commit 4d5fea9 into flutter:main Sep 12, 2024
@matanlurey matanlurey deleted the remove-litetest branch September 12, 2024 23:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 13, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 13, 2024
…155134)

flutter/engine@8609af6...4d5fea9

2024-09-12 [email protected] Remove all references to `litetest` from the engine repo. (flutter/engine#55163)
2024-09-12 [email protected] Roll Dart SDK from aa27c61f5859 to 23fc7751b8b2 (1 revision) (flutter/engine#55160)
2024-09-12 [email protected] Roll Skia from bcbc3038a8ad to 515a23f3cbe1 (2 revisions) (flutter/engine#55161)
2024-09-12 [email protected] Remove Impeller Scene ð��� (flutter/engine#55118)
2024-09-12 [email protected] Roll Skia from 26b048c6a53b to bcbc3038a8ad (3 revisions) (flutter/engine#55159)
2024-09-12 [email protected] Move `zircon_tests` from `package:litetest` to `package:async_helper`. (flutter/engine#55149)
2024-09-12 [email protected] Add a note about re generating Gradle lockfiles (flutter/engine#55150)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[engine] A wish for better Dart testing in the engine

3 participants