Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gmackall
Copy link
Member

Adds a note that Gradle lockfile generation is necessary when updating the android embedding dependencies bundle.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall marked this pull request as ready for review September 12, 2024 17:46
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 12, 2024

auto label is removed for flutter/engine/55150, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gmackall gmackall added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Sep 12, 2024
@auto-submit auto-submit bot merged commit c8fc350 into flutter:main Sep 12, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 12, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 13, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 13, 2024
…155134)

flutter/engine@8609af6...4d5fea9

2024-09-12 [email protected] Remove all references to `litetest` from the engine repo. (flutter/engine#55163)
2024-09-12 [email protected] Roll Dart SDK from aa27c61f5859 to 23fc7751b8b2 (1 revision) (flutter/engine#55160)
2024-09-12 [email protected] Roll Skia from bcbc3038a8ad to 515a23f3cbe1 (2 revisions) (flutter/engine#55161)
2024-09-12 [email protected] Remove Impeller Scene ð��� (flutter/engine#55118)
2024-09-12 [email protected] Roll Skia from 26b048c6a53b to bcbc3038a8ad (3 revisions) (flutter/engine#55159)
2024-09-12 [email protected] Move `zircon_tests` from `package:litetest` to `package:async_helper`. (flutter/engine#55149)
2024-09-12 [email protected] Add a note about re generating Gradle lockfiles (flutter/engine#55150)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants