This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Match Windows logic for picking RGB/BGR textures. #55121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code had a lot of additional checks that didn't seem to need to be there. BGR could be passed back to Flutter, but this was never used in creating the texture. There has been a report of a Flutter app on Linux with swapped red and blue color channels, so this seems like it is likely not working on some drivers. The original logic was introduced in f104bad
robert-ancell
force-pushed
the
linux-texture-bgra
branch
from
6e696a6 to
d8ae2d4
Compare
Member
|
Here's the corresponding Windows change: #54329 |
loic-sharma
reviewed
Sep 13, 2024
loic-sharma
approved these changes
Sep 13, 2024
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
LGTM, thanks for updating this!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2024
…155232) flutter/engine@fe22a19...9aaea5a 2024-09-16 [email protected] Match Windows logic for picking RGB/BGR textures. (flutter/engine#55121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code had a lot of additional checks that didn't seem to need to be there.
BGR could be passed back to Flutter, but this was never used in creating the texture.
There has been a report of a Flutter app on Linux with swapped red and blue color channels, so this seems like it is likely not working on some drivers.
The original logic was introduced in f104bad