Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matanlurey
Copy link
Contributor

Work towards flutter/flutter#133569.

After another PR, run_tests.py extra_args can be deleted entirely.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 10, 2024

auto label is removed for flutter/engine/55089, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2024
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2024
@auto-submit auto-submit bot merged commit 831b306 into flutter:main Sep 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 11, 2024
…154969)

flutter/engine@60c15bc...a26075f

2024-09-11 [email protected] Roll Dart SDK from 741512e72e92 to 22d8331d882e (1 revision) (flutter/engine#55094)
2024-09-10 [email protected] Move `flutter_frontend_server` and tweak `run_tests.py` to allow env variables. (flutter/engine#55089)
2024-09-10 [email protected] [Impeller] fix comment on savelayer utils. (flutter/engine#55049)
2024-09-10 [email protected] Roll Skia from 1760de26fb83 to 618beab475b6 (2 revisions) (flutter/engine#55088)
2024-09-10 [email protected] [Impeller] Fix memory leak I introduced by fixing memory leak. (flutter/engine#55087)
2024-09-10 [email protected] Remove the last `--disable-dart-dev` in the engine. (flutter/engine#55086)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jesswrd pushed a commit to jesswrd/engine that referenced this pull request Sep 11, 2024
…variables. (flutter#55089)

Work towards flutter/flutter#133569.

After another PR, `run_tests.py` `extra_args` can be deleted entirely.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants