This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Move flutter_frontend_server and tweak run_tests.py to allow env variables.
#55089
Merged
auto-submit
merged 2 commits into
flutter:main
from
matanlurey:flutter_frontend_server_run_tests
Sep 10, 2024
Merged
Move flutter_frontend_server and tweak run_tests.py to allow env variables.
#55089
auto-submit
merged 2 commits into
flutter:main
from
matanlurey:flutter_frontend_server_run_tests
Sep 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Sep 10, 2024
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
auto label is removed for flutter/engine/55089, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2024
…allow env variables. (flutter/engine#55089)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2024
…allow env variables. (flutter/engine#55089)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 11, 2024
…154969) flutter/engine@60c15bc...a26075f 2024-09-11 [email protected] Roll Dart SDK from 741512e72e92 to 22d8331d882e (1 revision) (flutter/engine#55094) 2024-09-10 [email protected] Move `flutter_frontend_server` and tweak `run_tests.py` to allow env variables. (flutter/engine#55089) 2024-09-10 [email protected] [Impeller] fix comment on savelayer utils. (flutter/engine#55049) 2024-09-10 [email protected] Roll Skia from 1760de26fb83 to 618beab475b6 (2 revisions) (flutter/engine#55088) 2024-09-10 [email protected] [Impeller] Fix memory leak I introduced by fixing memory leak. (flutter/engine#55087) 2024-09-10 [email protected] Remove the last `--disable-dart-dev` in the engine. (flutter/engine#55086) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jesswrd
pushed a commit
to jesswrd/engine
that referenced
this pull request
Sep 11, 2024
…variables. (flutter#55089) Work towards flutter/flutter#133569. After another PR, `run_tests.py` `extra_args` can be deleted entirely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#133569.
After another PR,
run_tests.pyextra_argscan be deleted entirely.