[Impeller] Fix memory leak I introduced by fixing memory leak. #55087
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
tested: benchmarks |
|
Fixes flutter/flutter#154951 |
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/55087, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jonahwilliams
added
the
autosubmit
…154969) flutter/engine@60c15bc...a26075f 2024-09-11 [email protected] Roll Dart SDK from 741512e72e92 to 22d8331d882e (1 revision) (flutter/engine#55094) 2024-09-10 [email protected] Move `flutter_frontend_server` and tweak `run_tests.py` to allow env variables. (flutter/engine#55089) 2024-09-10 [email protected] [Impeller] fix comment on savelayer utils. (flutter/engine#55049) 2024-09-10 [email protected] Roll Skia from 1760de26fb83 to 618beab475b6 (2 revisions) (flutter/engine#55088) 2024-09-10 [email protected] [Impeller] Fix memory leak I introduced by fixing memory leak. (flutter/engine#55087) 2024-09-10 [email protected] Remove the last `--disable-dart-dev` in the engine. (flutter/engine#55086) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er#55087) If we don't reset host buffer then leak
2 participants
If we don't reset host buffer then leak