This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Clean up macOS framework creation scripts #54658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Individual commits are broken out here for ease of review, if you prefer. Once this builds, I'll send out a framework test roll to verify and link below. |
zanderso
approved these changes
Aug 20, 2024
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
lgtm on green framework presubs
jmagman
reviewed
Aug 20, 2024
9 tasks
cbracken
added
the
test: all
Member
Author
|
Passed framework presubmits. |
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 21, 2024
…153808) flutter/engine@a6508d6...aa14223 2024-08-21 [email protected] Clean up macOS framework creation scripts (flutter/engine#54658) 2024-08-20 [email protected] Roll Skia from 51d7e221fef0 to 90671d1b342c (1 revision) (flutter/engine#54663) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153808) flutter/engine@a6508d6...aa14223 2024-08-21 [email protected] Clean up macOS framework creation scripts (flutter/engine#54658) 2024-08-20 [email protected] Roll Skia from 51d7e221fef0 to 90671d1b342c (1 revision) (flutter/engine#54663) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
create_fat_macos_framework,_regenerate_symlinksand_set_framework_permissionsto be more generic and not hardcode "FlutterMacOS"as a framework name. Further, it reuses several utility functions from the iOS
code in
sky_utilsto improve readability and eliminate duplication.This is refactoring prior to embedding dSYMs in FlutterMacOS.xcframework in a
followup patch.
Related issue: flutter/flutter#153879
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.