This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[canvaskit] Improve how overlays are optimized #54547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Aug 14, 2024
| /// | ||
| /// [paramsForViews] is required to compute the bounds of the platform views. | ||
| // TODO(harryterkelsen): Extend this to work for any sequence of platform views | ||
| // and pictures. |
| // it intersects with is "P_0", so we create a new render canvas and add "P_0" | ||
| // to it. | ||
| // The first picture is added to the rendering in a new render canvas. | ||
| RenderingRenderCanvas tentativeCanvas = RenderingRenderCanvas(); |
Contributor
There was a problem hiding this comment.
Can't quite parse all the possible situations when the loop below can exit. Is there a chance of the initial tentativeCanvas to never be used? If so, do we need to dispose of any resources it might be holding onto?
Contributor
Author
There was a problem hiding this comment.
It's possible for the tentativeCanvas to never be used. A RenderingRenderCanvas doesn't have any resources that need to be cleaned up until they are actually used and assigned a real RenderCanvas to paint their pictures to. Before that, they are basically just a list of pictures.
harryterkelsen
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 16, 2024
…153529) flutter/engine@8f3f80e...65fd6ca 2024-08-15 [email protected] [canvaskit] Improve how overlays are optimized (flutter/engine#54547) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…lutter#153529) flutter/engine@8f3f80e...65fd6ca 2024-08-15 [email protected] [canvaskit] Improve how overlays are optimized (flutter/engine#54547) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153529) flutter/engine@8f3f80e...65fd6ca 2024-08-15 [email protected] [canvaskit] Improve how overlays are optimized (flutter/engine#54547) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the overlay optimization by pushing new pictures to the earliest RenderCanvas they can go into. This improvement is made especially clear in the new test case I added to
embedded_views_test.dart, with the previous algorithm we would have used an overlay for each platform view even though all of the pictures could go into the base canvas with no issue.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.