This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove shared mutex from FML and use the C++17 variants. #54482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to require this only on iOS because the standard library till iOS 9 didn't have support for this. We have moved past that version. No change on other platforms.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/54482, due to - The status or check suite Windows windows_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 10, 2024
…153210) flutter/engine@2f577d8...3acd373 2024-08-10 [email protected] Revert "Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (#54474)" (flutter/engine#54487) 2024-08-09 [email protected] Remove shared mutex from FML and use the C++17 variants. (flutter/engine#54482) 2024-08-09 [email protected] Roll Skia from 2a7e7567607e to eeffce72693c (1 revision) (flutter/engine#54480) 2024-08-09 [email protected] Roll Fuchsia Test Scripts from ra4HZdsFPpgZgDON6... to q3WfgLnPmQ-1lBu8M... (flutter/engine#54479) 2024-08-09 [email protected] Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (flutter/engine#54474) 2024-08-09 [email protected] Roll Skia from 5e190559fefd to 2a7e7567607e (1 revision) (flutter/engine#54477) 2024-08-09 [email protected] Remove fml::size. (flutter/engine#54476) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…lutter#153210) flutter/engine@2f577d8...3acd373 2024-08-10 [email protected] Revert "Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (flutter#54474)" (flutter/engine#54487) 2024-08-09 [email protected] Remove shared mutex from FML and use the C++17 variants. (flutter/engine#54482) 2024-08-09 [email protected] Roll Skia from 2a7e7567607e to eeffce72693c (1 revision) (flutter/engine#54480) 2024-08-09 [email protected] Roll Fuchsia Test Scripts from ra4HZdsFPpgZgDON6... to q3WfgLnPmQ-1lBu8M... (flutter/engine#54479) 2024-08-09 [email protected] Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (flutter/engine#54474) 2024-08-09 [email protected] Roll Skia from 5e190559fefd to 2a7e7567607e (1 revision) (flutter/engine#54477) 2024-08-09 [email protected] Remove fml::size. (flutter/engine#54476) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153210) flutter/engine@2f577d8...3acd373 2024-08-10 [email protected] Revert "Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (flutter#54474)" (flutter/engine#54487) 2024-08-09 [email protected] Remove shared mutex from FML and use the C++17 variants. (flutter/engine#54482) 2024-08-09 [email protected] Roll Skia from 2a7e7567607e to eeffce72693c (1 revision) (flutter/engine#54480) 2024-08-09 [email protected] Roll Fuchsia Test Scripts from ra4HZdsFPpgZgDON6... to q3WfgLnPmQ-1lBu8M... (flutter/engine#54479) 2024-08-09 [email protected] Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (flutter/engine#54474) 2024-08-09 [email protected] Roll Skia from 5e190559fefd to 2a7e7567607e (1 revision) (flutter/engine#54477) 2024-08-09 [email protected] Remove fml::size. (flutter/engine#54476) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to require this only on iOS because the standard library till iOS 9 didn't have support for this. We have moved past that version. No change on other platforms.