This repository was archived by the owner on Feb 25, 2025. It is now read-only.
macOS: Fix crash in attributedSubstringForProposedRange with out of bounds range #54469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopp
changed the title
knopp
changed the title
cbracken
approved these changes
Aug 12, 2024
Member
There was a problem hiding this comment.
Thanks for fixing! I remember adding a ton of mitigations for this sort of things when I wrote the original UITextInput implementation on iOS. I haven't read the equivalent protocol docs for macOS but I imagine that similar to UIKit, AppKit APIs reserve the right to pass you out-of-bounds values that we may not be protecting against :/
Contributor
|
Can we submit this? |
Contributor
|
Thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2024
…h out of bounds range (flutter/engine#54469)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 12, 2024
…153313) flutter/engine@bcf2dcc...5d8ee52 2024-08-12 [email protected] macOS: Fix crash in attributedSubstringForProposedRange with out of bounds range (flutter/engine#54469) 2024-08-12 [email protected] [Windows] Improve texture format logic (flutter/engine#54329) 2024-08-12 [email protected] Revert "[Impeller] remove scene3d support." (flutter/engine#54502) 2024-08-12 [email protected] Roll Skia from f77adcef7c1c to ec7558d41b34 (1 revision) (flutter/engine#54507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…lutter#153313) flutter/engine@bcf2dcc...5d8ee52 2024-08-12 [email protected] macOS: Fix crash in attributedSubstringForProposedRange with out of bounds range (flutter/engine#54469) 2024-08-12 [email protected] [Windows] Improve texture format logic (flutter/engine#54329) 2024-08-12 [email protected] Revert "[Impeller] remove scene3d support." (flutter/engine#54502) 2024-08-12 [email protected] Roll Skia from f77adcef7c1c to ec7558d41b34 (1 revision) (flutter/engine#54507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153313) flutter/engine@bcf2dcc...5d8ee52 2024-08-12 [email protected] macOS: Fix crash in attributedSubstringForProposedRange with out of bounds range (flutter/engine#54469) 2024-08-12 [email protected] [Windows] Improve texture format logic (flutter/engine#54329) 2024-08-12 [email protected] Revert "[Impeller] remove scene3d support." (flutter/engine#54502) 2024-08-12 [email protected] Roll Skia from f77adcef7c1c to ec7558d41b34 (1 revision) (flutter/engine#54507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#153157
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.