This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] remove scene3d support. #54453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2024 12:15
chinmaygarde
approved these changes
Aug 8, 2024
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
cc @bdero if he can think of any reason we should keep this around still.
Contributor
Author
|
We can revert if there are issues. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 9, 2024
…153191) flutter/engine@4d5b1df...2f577d8 2024-08-09 [email protected] [Impeller] Add FAQ entries. (flutter/engine#54456) 2024-08-09 [email protected] Roll Skia from f5dc4483204d to 5e190559fefd (1 revision) (flutter/engine#54472) 2024-08-09 [email protected] Roll Skia from 13b4fee1ba99 to f5dc4483204d (1 revision) (flutter/engine#54471) 2024-08-09 [email protected] [Impeller] remove scene3d support. (flutter/engine#54453) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
|
Not quite ready to remove this yet because I'm still porting the animation stuff to flutter_scene. |
Member
|
reason for revert: Not quite ready to remove this yet because I'm still porting the animation stuff to flutter_scene. |
bdero
added
the
revert
Contributor
|
Time to revert pull request flutter/engine/54453 has elapsed. |
auto-submit
bot
removed
the
revert
bdero
added a commit
that referenced
this pull request
Aug 12, 2024
Reverts #54453 Not quite ready to remove Impeller Scene yet because I'm still porting the animation functionality. Keeping it around allows me to switch back and forth to compare without having to recompile the engine. Over a month ago I said something like "we can revert this a couple of weeks from now" in one of the Impeller meetings. But for better or worse (better, I think), I ended up spending a ton of time trying to make the PBR good first (which doesn't exist in this C++ version).
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…lutter#153191) flutter/engine@4d5b1df...2f577d8 2024-08-09 [email protected] [Impeller] Add FAQ entries. (flutter/engine#54456) 2024-08-09 [email protected] Roll Skia from f5dc4483204d to 5e190559fefd (1 revision) (flutter/engine#54472) 2024-08-09 [email protected] Roll Skia from 13b4fee1ba99 to f5dc4483204d (1 revision) (flutter/engine#54471) 2024-08-09 [email protected] [Impeller] remove scene3d support. (flutter/engine#54453) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153191) flutter/engine@4d5b1df...2f577d8 2024-08-09 [email protected] [Impeller] Add FAQ entries. (flutter/engine#54456) 2024-08-09 [email protected] Roll Skia from f5dc4483204d to 5e190559fefd (1 revision) (flutter/engine#54472) 2024-08-09 [email protected] Roll Skia from 13b4fee1ba99 to f5dc4483204d (1 revision) (flutter/engine#54471) 2024-08-09 [email protected] [Impeller] remove scene3d support. (flutter/engine#54453) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Flutter GPU is a preview, the technical debt from having an ifdef controlled additional rendering mode can be removed.