This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Impeller] Reland 2: Implement draw order optimization. (#54268) #54325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter#54268)" This reverts commit 4dc94d6.
jason-simmons
approved these changes
Aug 2, 2024
Member
|
(see internal issue b/356986762) |
Contributor
|
auto label is removed for flutter/engine/54325, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
jonahwilliams
added
the
autosubmit
Contributor
|
adding autosub |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 3, 2024
…152814) flutter/engine@afb7007...4c868ee 2024-08-03 [email protected] Revert "[Impeller] Reland 2: Implement draw order optimization. (#54268) (flutter/engine#54325) 2024-08-03 [email protected] Roll Dart SDK from 3a0b4143fe47 to d4a2c6a52b4a (1 revision) (flutter/engine#54334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152814) flutter/engine@afb7007...4c868ee 2024-08-03 [email protected] Revert "[Impeller] Reland 2: Implement draw order optimization. (flutter#54268) (flutter/engine#54325) 2024-08-03 [email protected] Roll Dart SDK from 3a0b4143fe47 to d4a2c6a52b4a (1 revision) (flutter/engine#54334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152814) flutter/engine@afb7007...4c868ee 2024-08-03 [email protected] Revert "[Impeller] Reland 2: Implement draw order optimization. (flutter#54268) (flutter/engine#54325) 2024-08-03 [email protected] Roll Dart SDK from 3a0b4143fe47 to d4a2c6a52b4a (1 revision) (flutter/engine#54334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual revert of #54268, since the time expired for automatic reverting.
@jason-simmons found this patch to be causing a regression in a downstream app. Some draws are getting clipped away, and disabling the scissor fixes it. So there is likely still a case not being handled correctly with the clip replay or subpass draw deferral behavior.