This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add SK_USE_LEGACY_BLUR_RASTER staging flag #54314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skia's CPU-based blur implementation is inaccurate for sigma < 2, but the Dart imagefilter test uses a case with sigma = 1. In https://skia-review.googlesource.com/c/skia/+/885107, the algorithm is updated to be more accurate when sigma < 2, so the output is more accurate. In order to roll into flutter, the expected color values in the tests will need to be updated with the removal of this staging flag.
chinmaygarde
approved these changes
Aug 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 5, 2024
…152868) flutter/engine@0aac603...1bfd06c 2024-08-05 [email protected] Roll Dart SDK from d4a2c6a52b4a to bdeaec130e8e (1 revision) (flutter/engine#54344) 2024-08-05 [email protected] Add SK_USE_LEGACY_BLUR_RASTER staging flag (flutter/engine#54314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152868) flutter/engine@0aac603...1bfd06c 2024-08-05 [email protected] Roll Dart SDK from d4a2c6a52b4a to bdeaec130e8e (1 revision) (flutter/engine#54344) 2024-08-05 [email protected] Add SK_USE_LEGACY_BLUR_RASTER staging flag (flutter/engine#54314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152868) flutter/engine@0aac603...1bfd06c 2024-08-05 [email protected] Roll Dart SDK from d4a2c6a52b4a to bdeaec130e8e (1 revision) (flutter/engine#54344) 2024-08-05 [email protected] Add SK_USE_LEGACY_BLUR_RASTER staging flag (flutter/engine#54314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skia's CPU-based blur implementation is inaccurate for sigma < 2, but the Dart imagefilter test uses a case with sigma = 1.
In https://skia-review.googlesource.com/c/skia/+/885107, the algorithm is updated to be more accurate when sigma < 2, so the output is more accurate. In order to roll into flutter, the expected color values in the tests will need to be updated with the removal of this staging flag.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.