This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Use InetAddress.getLoopback() versus a string.
#54289
Merged
auto-submit
merged 1 commit into
flutter:main
from
matanlurey:screenshot-util-inet-address
Aug 1, 2024
Merged
Use InetAddress.getLoopback() versus a string.
#54289
auto-submit
merged 1 commit into
flutter:main
from
matanlurey:screenshot-util-inet-address
Aug 1, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
approved these changes
Aug 1, 2024
Contributor
camsim99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 2, 2024
…152718) flutter/engine@1cbe88e...ab3f177 2024-08-01 [email protected] Roll Fuchsia Linux SDK from uF76DfQgigt4utdBv... to vpJQheqicAUK_qjD-... (flutter/engine#54295) 2024-08-01 [email protected] [skwasm] Implement platform view clipping. (flutter/engine#54201) 2024-08-01 [email protected] Roll Skia from ddb6901e6141 to 5c229d4d20bb (3 revisions) (flutter/engine#54288) 2024-08-01 [email protected] Use `InetAddress.getLoopback()` versus a string. (flutter/engine#54289) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from uF76DfQgigt4 to vpJQheqicAUK If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152718) flutter/engine@1cbe88e...ab3f177 2024-08-01 [email protected] Roll Fuchsia Linux SDK from uF76DfQgigt4utdBv... to vpJQheqicAUK_qjD-... (flutter/engine#54295) 2024-08-01 [email protected] [skwasm] Implement platform view clipping. (flutter/engine#54201) 2024-08-01 [email protected] Roll Skia from ddb6901e6141 to 5c229d4d20bb (3 revisions) (flutter/engine#54288) 2024-08-01 [email protected] Use `InetAddress.getLoopback()` versus a string. (flutter/engine#54289) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from uF76DfQgigt4 to vpJQheqicAUK If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152718) flutter/engine@1cbe88e...ab3f177 2024-08-01 [email protected] Roll Fuchsia Linux SDK from uF76DfQgigt4utdBv... to vpJQheqicAUK_qjD-... (flutter/engine#54295) 2024-08-01 [email protected] [skwasm] Implement platform view clipping. (flutter/engine#54201) 2024-08-01 [email protected] Roll Skia from ddb6901e6141 to 5c229d4d20bb (3 revisions) (flutter/engine#54288) 2024-08-01 [email protected] Use `InetAddress.getLoopback()` versus a string. (flutter/engine#54289) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from uF76DfQgigt4 to vpJQheqicAUK If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just better anyway, and will work around an Android 35 failure we're investigating.