Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matanlurey
Copy link
Contributor

This is just better anyway, and will work around an Android 35 failure we're investigating.

@matanlurey matanlurey requested a review from camsim99 August 1, 2024 20:19
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2024
@auto-submit auto-submit bot merged commit 593c222 into flutter:main Aug 1, 2024
@matanlurey matanlurey deleted the screenshot-util-inet-address branch August 1, 2024 21:04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 2, 2024
…152718)

flutter/engine@1cbe88e...ab3f177

2024-08-01 [email protected] Roll Fuchsia Linux SDK from uF76DfQgigt4utdBv... to vpJQheqicAUK_qjD-... (flutter/engine#54295)
2024-08-01 [email protected] [skwasm] Implement platform view clipping. (flutter/engine#54201)
2024-08-01 [email protected] Roll Skia from ddb6901e6141 to 5c229d4d20bb (3 revisions) (flutter/engine#54288)
2024-08-01 [email protected] Use `InetAddress.getLoopback()` versus a string. (flutter/engine#54289)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from uF76DfQgigt4 to vpJQheqicAUK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…lutter#152718)

flutter/engine@1cbe88e...ab3f177

2024-08-01 [email protected] Roll Fuchsia Linux SDK from uF76DfQgigt4utdBv... to vpJQheqicAUK_qjD-... (flutter/engine#54295)
2024-08-01 [email protected] [skwasm] Implement platform view clipping. (flutter/engine#54201)
2024-08-01 [email protected] Roll Skia from ddb6901e6141 to 5c229d4d20bb (3 revisions) (flutter/engine#54288)
2024-08-01 [email protected] Use `InetAddress.getLoopback()` versus a string. (flutter/engine#54289)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from uF76DfQgigt4 to vpJQheqicAUK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#152718)

flutter/engine@1cbe88e...ab3f177

2024-08-01 [email protected] Roll Fuchsia Linux SDK from uF76DfQgigt4utdBv... to vpJQheqicAUK_qjD-... (flutter/engine#54295)
2024-08-01 [email protected] [skwasm] Implement platform view clipping. (flutter/engine#54201)
2024-08-01 [email protected] Roll Skia from ddb6901e6141 to 5c229d4d20bb (3 revisions) (flutter/engine#54288)
2024-08-01 [email protected] Use `InetAddress.getLoopback()` versus a string. (flutter/engine#54289)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from uF76DfQgigt4 to vpJQheqicAUK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants