This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Reland 2: Implement draw order optimization. #54268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original PR: flutter#54136 Revert PR: flutter#54067
This reverts commit 6919636.
bdero
force-pushed
the
bdero/reland2-draw-order-optimization
branch
from
8bd048a to
357e292
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2024
…152663) flutter/engine@f546fef...4dc94d6 2024-08-01 [email protected] [Impeller] Reland 2: Implement draw order optimization. (flutter/engine#54268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
Author
|
Reason for revert: A downstream app reproduced and issue where certain draws are getting drawn with an incorrect scissor and getting clipped out. (@jason-simmons tracked the issue to this commit) |
bdero
added
the
revert
Contributor
|
Time to revert pull request flutter/engine/54268 has elapsed. |
auto-submit
bot
removed
the
revert
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Aug 2, 2024
…ter#54268)" This reverts commit 4dc94d6.
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 3, 2024
…) (#54325) Manual revert of #54268, since the time expired for automatic reverting. @jason-simmons found this patch to be causing a regression in a downstream app. Some draws are getting clipped away, and disabling the scissor fixes it. So there is likely still a case not being handled correctly with the clip replay or subpass draw deferral behavior.
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152663) flutter/engine@f546fef...4dc94d6 2024-08-01 [email protected] [Impeller] Reland 2: Implement draw order optimization. (flutter/engine#54268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152663) flutter/engine@f546fef...4dc94d6 2024-08-01 [email protected] [Impeller] Reland 2: Implement draw order optimization. (flutter/engine#54268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt 1: #54136
Revert 1: #54067
Attempt 2: #54215
Revert 2: #54261
This time for sure!
Includes fix for the golden failures seen here: https://flutter-gold.skia.org/search?issue=152633&crs=github&patchsets=2&corpus=flutter
The break in the clear color counter was in the wrong spot, so the counter wasn't breaking when coming across subpass elements (which are never considered to be clear-colors right now). This caused the counter to continue counting entities after subpasses sometimes, which can cause the count to end up too high and skip over non-clear color elements.
Description
For each clip scope, draw opaque items in reverse order and translucent/backdrop-independent items in their original order afterwards. Clips are treated as translucent by the parent scope.
Respects clips, subpass collapse, and the clear color optimization.
Local new_gallery before/after (iPhone 12 mini):