Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

In 2021, we did some experiments with ML-guided optimisations in the
engine. Ultimately, these didn't provide much benefit, and much of the
information in the documentation is now out-of-date.

For those who need it, this can always be found in the git history.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

In 2021, we did some experiments with ML-guided optimisations in the
engine. Ultimately, these didn't provide much benefit, and much of the
information in the documentation is now out-of-date.

For those who need it, this can always be found in the git history.
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 30, 2024
@auto-submit auto-submit bot merged commit 83b3936 into flutter:main Jul 31, 2024
@cbracken cbracken deleted the remove-outdated-doc branch July 31, 2024 00:20
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 31, 2024
…152592)

flutter/engine@e2ece7e...b73367a

2024-07-31 [email protected] Update flutter_shell_native_unittests for compatibility with Android API 35 emulators (flutter/engine#54235)
2024-07-31 [email protected] [docs] Delete obsolete ML guided optimisation doc (flutter/engine#54237)
2024-07-31 [email protected] Roll Dart SDK from e16dc217b1ac to 68e559110999 (1 revision) (flutter/engine#54236)
2024-07-30 [email protected] enumify ImageType and ImageFileSignature (flutter/engine#54131)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…lutter#152592)

flutter/engine@e2ece7e...b73367a

2024-07-31 [email protected] Update flutter_shell_native_unittests for compatibility with Android API 35 emulators (flutter/engine#54235)
2024-07-31 [email protected] [docs] Delete obsolete ML guided optimisation doc (flutter/engine#54237)
2024-07-31 [email protected] Roll Dart SDK from e16dc217b1ac to 68e559110999 (1 revision) (flutter/engine#54236)
2024-07-30 [email protected] enumify ImageType and ImageFileSignature (flutter/engine#54131)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#152592)

flutter/engine@e2ece7e...b73367a

2024-07-31 [email protected] Update flutter_shell_native_unittests for compatibility with Android API 35 emulators (flutter/engine#54235)
2024-07-31 [email protected] [docs] Delete obsolete ML guided optimisation doc (flutter/engine#54237)
2024-07-31 [email protected] Roll Dart SDK from e16dc217b1ac to 68e559110999 (1 revision) (flutter/engine#54236)
2024-07-30 [email protected] enumify ImageType and ImageFileSignature (flutter/engine#54131)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants