This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[docs] Delete obsolete ML guided optimisation doc #54237
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2021, we did some experiments with ML-guided optimisations in the engine. Ultimately, these didn't provide much benefit, and much of the information in the documentation is now out-of-date. For those who need it, this can always be found in the git history.
jonahwilliams
approved these changes
Jul 30, 2024
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
zanderso
approved these changes
Jul 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 31, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 31, 2024
…152592) flutter/engine@e2ece7e...b73367a 2024-07-31 [email protected] Update flutter_shell_native_unittests for compatibility with Android API 35 emulators (flutter/engine#54235) 2024-07-31 [email protected] [docs] Delete obsolete ML guided optimisation doc (flutter/engine#54237) 2024-07-31 [email protected] Roll Dart SDK from e16dc217b1ac to 68e559110999 (1 revision) (flutter/engine#54236) 2024-07-30 [email protected] enumify ImageType and ImageFileSignature (flutter/engine#54131) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152592) flutter/engine@e2ece7e...b73367a 2024-07-31 [email protected] Update flutter_shell_native_unittests for compatibility with Android API 35 emulators (flutter/engine#54235) 2024-07-31 [email protected] [docs] Delete obsolete ML guided optimisation doc (flutter/engine#54237) 2024-07-31 [email protected] Roll Dart SDK from e16dc217b1ac to 68e559110999 (1 revision) (flutter/engine#54236) 2024-07-30 [email protected] enumify ImageType and ImageFileSignature (flutter/engine#54131) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152592) flutter/engine@e2ece7e...b73367a 2024-07-31 [email protected] Update flutter_shell_native_unittests for compatibility with Android API 35 emulators (flutter/engine#54235) 2024-07-31 [email protected] [docs] Delete obsolete ML guided optimisation doc (flutter/engine#54237) 2024-07-31 [email protected] Roll Dart SDK from e16dc217b1ac to 68e559110999 (1 revision) (flutter/engine#54236) 2024-07-30 [email protected] enumify ImageType and ImageFileSignature (flutter/engine#54131) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2021, we did some experiments with ML-guided optimisations in the
engine. Ultimately, these didn't provide much benefit, and much of the
information in the documentation is now out-of-date.
For those who need it, this can always be found in the git history.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.