This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] delete rasterizer class. #54196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jul 29, 2024
Contributor
Author
|
Wait, i forgot to call Present lol |
Contributor
Author
|
okay fixed. |
chinmaygarde
approved these changes
Jul 29, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 30, 2024
…152524) flutter/engine@49324cd...cb96743 2024-07-29 [email protected] [Impeller] delete rasterizer class. (flutter/engine#54196) 2024-07-29 [email protected] Roll Skia from 62e955dbaef0 to 832023dc041a (1 revision) (flutter/engine#54198) 2024-07-29 [email protected] [wiki] Fix link to engine dev setup (flutter/engine#54173) 2024-07-29 [email protected] Roll Dart SDK from 9a6e058303af to e8eca6f05494 (2 revisions) (flutter/engine#54197) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152524) flutter/engine@49324cd...cb96743 2024-07-29 [email protected] [Impeller] delete rasterizer class. (flutter/engine#54196) 2024-07-29 [email protected] Roll Skia from 62e955dbaef0 to 832023dc041a (1 revision) (flutter/engine#54198) 2024-07-29 [email protected] [wiki] Fix link to engine dev setup (flutter/engine#54173) 2024-07-29 [email protected] Roll Dart SDK from 9a6e058303af to e8eca6f05494 (2 revisions) (flutter/engine#54197) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152524) flutter/engine@49324cd...cb96743 2024-07-29 [email protected] [Impeller] delete rasterizer class. (flutter/engine#54196) 2024-07-29 [email protected] Roll Skia from 62e955dbaef0 to 832023dc041a (1 revision) (flutter/engine#54198) 2024-07-29 [email protected] [wiki] Fix link to engine dev setup (flutter/engine#54173) 2024-07-29 [email protected] Roll Dart SDK from 9a6e058303af to e8eca6f05494 (2 revisions) (flutter/engine#54197) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rasterizer class doesn't actually do anything besides call impeller::Surface to get the render target. lets just remove it. Simplifies refactores needed to make #53826 work well.