Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@aam
Copy link
Member

@aam aam commented Jul 29, 2024

Follow-up to b0d1df5 - remove obsolete dependency from few more places that were missed.

@aam aam requested a review from jason-simmons July 29, 2024 16:19
@aam aam merged commit d1995f3 into flutter:main Jul 29, 2024
@aam aam deleted the remove-more-obsolette-deps branch July 29, 2024 16:37
@aam
Copy link
Member Author

aam commented Jul 29, 2024

thanks Jason

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 29, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 29, 2024
…152496)

flutter/engine@d803bb1...d1995f3

2024-07-29 [email protected] Remove obsolete dependency from few more targets. (flutter/engine#54181)
2024-07-29 [email protected] [web] Fix scaledImageSize handling of a target width with no target height (flutter/engine#54122)
2024-07-29 [email protected] Roll Skia from 940c71c61d11 to 4a65e626ebbe (4 revisions) (flutter/engine#54180)
2024-07-29 [email protected] Roll Skia from f5a8dfda1131 to 940c71c61d11 (1 revision) (flutter/engine#54179)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…lutter#152496)

flutter/engine@d803bb1...d1995f3

2024-07-29 [email protected] Remove obsolete dependency from few more targets. (flutter/engine#54181)
2024-07-29 [email protected] [web] Fix scaledImageSize handling of a target width with no target height (flutter/engine#54122)
2024-07-29 [email protected] Roll Skia from 940c71c61d11 to 4a65e626ebbe (4 revisions) (flutter/engine#54180)
2024-07-29 [email protected] Roll Skia from f5a8dfda1131 to 940c71c61d11 (1 revision) (flutter/engine#54179)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#152496)

flutter/engine@d803bb1...d1995f3

2024-07-29 [email protected] Remove obsolete dependency from few more targets. (flutter/engine#54181)
2024-07-29 [email protected] [web] Fix scaledImageSize handling of a target width with no target height (flutter/engine#54122)
2024-07-29 [email protected] Roll Skia from 940c71c61d11 to 4a65e626ebbe (4 revisions) (flutter/engine#54180)
2024-07-29 [email protected] Roll Skia from f5a8dfda1131 to 940c71c61d11 (1 revision) (flutter/engine#54179)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants