This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix a race in file I/O done by a BuildRunner test #54167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test failure had been seen in some recent auto-roller jobs on CI.
| final io.File file = | ||
| io.File(path.join(hostDebug.path, 'compile_commands.json')); | ||
| file.writeAsString( | ||
| file.writeAsStringSync( |
Contributor
There was a problem hiding this comment.
I'd expect that an unawaited futures lint would have caught this
Member
Author
There was a problem hiding this comment.
The Dart analyzer's unawaited_futures check does warn about this.
But that check was disabled due to false positives (see https://github.com/flutter/engine/blob/main/analysis_options.yaml#L197)
zanderso
approved these changes
Jul 28, 2024
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 28, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 28, 2024
…152446) flutter/engine@dfdb2d5...f0effaa 2024-07-28 [email protected] Fix a race in file I/O done by a BuildRunner test (flutter/engine#54167) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152446) flutter/engine@dfdb2d5...f0effaa 2024-07-28 [email protected] Fix a race in file I/O done by a BuildRunner test (flutter/engine#54167) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152446) flutter/engine@dfdb2d5...f0effaa 2024-07-28 [email protected] Fix a race in file I/O done by a BuildRunner test (flutter/engine#54167) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test failure had been seen in some recent auto-roller jobs on CI.