This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Enable on-by-default on Android. #54156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Developers can control the backend in the following ways: Do nothing: Impeller with Vulkan is used where Vulkan is available with a fallback to Skia with OpenGL. In `AndroidManifest.xml`, specify `io.flutter.embedding.android.EnableImpeller` as `false`: Skia with OpenGL is used. On the command line, specify `--no-enable-impeller`: Skia with OpenGL is used. Manifest options will take priority command line options when there is a conflict. This matches iOS behavior per flutter/flutter#124049 (closed as WAI). Fixes flutter/flutter#149360
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Android is a bit different from iOS in that it doesn't work with a |
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
#53099 changed a few more files, I think you'll need to make sure scenario app is running as expected
Member
|
Did a pass for TODOs, but I'm sure I didn't find everything. Only thing I found with a quick search was flutter/flutter#132712. |
zanderso
approved these changes
Jul 27, 2024
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 29, 2024
…152464) flutter/engine@7f7ad74...2cf3986 2024-07-29 [email protected] [Impeller] Enable on-by-default on Android. (flutter/engine#54156) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
chinmaygarde
added a commit
to flutter/flutter
that referenced
this pull request
Jul 29, 2024
It is as of flutter/engine#54156. Fixes #132712
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152464) flutter/engine@7f7ad74...2cf3986 2024-07-29 [email protected] [Impeller] Enable on-by-default on Android. (flutter/engine#54156) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152464) flutter/engine@7f7ad74...2cf3986 2024-07-29 [email protected] [Impeller] Enable on-by-default on Android. (flutter/engine#54156) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers can control the backend in the following ways:
AndroidManifest.xml, specifyio.flutter.embedding.android.EnableImpellerasfalse: Skia with OpenGL is used.--no-enable-impeller: Skia with OpenGL is used.Manifest options will take priority command line options when there is a conflict. This matches iOS behavior per flutter/flutter#124049 (closed as WAI).
Fixes flutter/flutter#149360