This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor detectContentType to prepare for animation detection #54127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file will grow as we add more sophisticated format detection
harryterkelsen
added
the
autosubmit
kevmoo
reviewed
Jul 25, 2024
| } | ||
|
|
||
| /// Represents an image file format, such as PNG or JPEG. | ||
| class ImageFileFormat { |
Contributor
There was a problem hiding this comment.
This could be an enum, right? Or do you want this to be runtime extensible?
Contributor
There was a problem hiding this comment.
Then you could merge this class and the type enum...
kevmoo
reviewed
Jul 25, 2024
| } | ||
|
|
||
| /// The file format of the image, and whether or not it is animated. | ||
| class ImageType { |
Contributor
There was a problem hiding this comment.
This could be collapsed into the enum, too – right?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 26, 2024
…152351) flutter/engine@21629ec...8714b54 2024-07-25 [email protected] Refactor detectContentType to prepare for animation detection (flutter/engine#54127) 2024-07-25 [email protected] Roll Dart SDK from 529fda259fdf to 3fcce71dbe82 (1 revision) (flutter/engine#54128) 2024-07-25 [email protected] Roll Skia from 529569ce068a to e9b8585af6b5 (13 revisions) (flutter/engine#54125) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152351) flutter/engine@21629ec...8714b54 2024-07-25 [email protected] Refactor detectContentType to prepare for animation detection (flutter/engine#54127) 2024-07-25 [email protected] Roll Dart SDK from 529fda259fdf to 3fcce71dbe82 (1 revision) (flutter/engine#54128) 2024-07-25 [email protected] Roll Skia from 529569ce068a to e9b8585af6b5 (13 revisions) (flutter/engine#54125) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152351) flutter/engine@21629ec...8714b54 2024-07-25 [email protected] Refactor detectContentType to prepare for animation detection (flutter/engine#54127) 2024-07-25 [email protected] Roll Dart SDK from 529fda259fdf to 3fcce71dbe82 (1 revision) (flutter/engine#54128) 2024-07-25 [email protected] Roll Skia from 529569ce068a to e9b8585af6b5 (13 revisions) (flutter/engine#54125) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor in preparation for flutter/flutter#151911
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.