This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix retain cycle in FlutterMetalLayer #54119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopp
force-pushed
the
flutter_metal_layer_retain_cycle
branch
from
05fc118 to
e8aafd3
Compare
jonahwilliams
added
the
autosubmit
jmagman
reviewed
Jul 25, 2024
|
|
||
| - (void)dealloc { | ||
| [_displayLink invalidate]; | ||
| [[NSNotificationCenter defaultCenter] removeObserver:self]; |
Member
There was a problem hiding this comment.
This isn't necessary in dealloc.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 25, 2024
…152340) flutter/engine@74785a7...d665bf8 2024-07-25 [email protected] Fix retain cycle in FlutterMetalLayer (flutter/engine#54119) 2024-07-25 [email protected] Roll Dart SDK from 3d584310ee21 to 529fda259fdf (1 revision) (flutter/engine#54117) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152340) flutter/engine@74785a7...d665bf8 2024-07-25 [email protected] Fix retain cycle in FlutterMetalLayer (flutter/engine#54119) 2024-07-25 [email protected] Roll Dart SDK from 3d584310ee21 to 529fda259fdf (1 revision) (flutter/engine#54117) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
13 tasks
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152340) flutter/engine@74785a7...d665bf8 2024-07-25 [email protected] Fix retain cycle in FlutterMetalLayer (flutter/engine#54119) 2024-07-25 [email protected] Roll Dart SDK from 3d584310ee21 to 529fda259fdf (1 revision) (flutter/engine#54117) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.