This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Initial pass to cleanup dom.dart to use newer JS interop styles #54093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were needed for when we lowered things on the procedure side, but since we have invocation-sensitive lowerings, we don't need to worry about accidentally providing more arguments than were passed by the interop method caller.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ditman
approved these changes
Jul 25, 2024
Member
|
I think the code in dom.dart should be indirectly tested by the tests of the web engine (that run in browser) |
Contributor
Author
|
Thanks!
Yup! Right now it just has a TODO on it, but I want to make this a proper deprecation. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 26, 2024
…152344) flutter/engine@d665bf8...21629ec 2024-07-25 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.12 to 3.25.13 (flutter/engine#54039) 2024-07-25 [email protected] Initial pass to cleanup dom.dart to use newer JS interop styles (flutter/engine#54093) 2024-07-25 [email protected] Roll buildroot to e92499322525306bd637eb79d1e6dd507d5f3062 (flutter/engine#54113) 2024-07-25 [email protected] [iOS] enable FlutterMetalLayer. (flutter/engine#54121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152344) flutter/engine@d665bf8...21629ec 2024-07-25 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.12 to 3.25.13 (flutter/engine#54039) 2024-07-25 [email protected] Initial pass to cleanup dom.dart to use newer JS interop styles (flutter/engine#54093) 2024-07-25 [email protected] Roll buildroot to e92499322525306bd637eb79d1e6dd507d5f3062 (flutter/engine#54113) 2024-07-25 [email protected] [iOS] enable FlutterMetalLayer. (flutter/engine#54121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152344) flutter/engine@d665bf8...21629ec 2024-07-25 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.12 to 3.25.13 (flutter/engine#54039) 2024-07-25 [email protected] Initial pass to cleanup dom.dart to use newer JS interop styles (flutter/engine#54093) 2024-07-25 [email protected] Roll buildroot to e92499322525306bd637eb79d1e6dd507d5f3062 (flutter/engine#54113) 2024-07-25 [email protected] [iOS] enable FlutterMetalLayer. (flutter/engine#54121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only addresses the following:
JSVoidin favor ofvoid.JSVoid, which is just a typedef, should be deprecated and removed eventually.Still left to do (not comprehensive):
js_util.package:webequivalent for easier maintenance.