[Impeller] Convert basic AIKS golden tests to use DisplayList #53969
Conversation
|
Assertion that this cannot affect anything outside of the new engine tests in its current form:
Combined those 2 assertions mean that Dart code cannot use this new mechanism (yet). |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
I believe the differences in the round rect goldens are due to minor math differences between:
I'm thinking that the test should use Builder::DrawRRect() (I just pushed a change to use DrawRRect in that test instead of costructing an SkPath) |
|
Golden file changes are available for triage from new commit, Click here to view. |
That seems reasonable to me! |
|
I'm checking with @jiahaog to see if I should dry run this through the internal "mass golden test changes" tool first just to verify that it won't affect anything... |
…151927) flutter/engine@d194a2f...00f0f6b 2024-07-17 [email protected] [Impeller] Convert basic AIKS golden tests to use DisplayList (flutter/engine#53969) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#151927) flutter/engine@d194a2f...00f0f6b 2024-07-17 [email protected] [Impeller] Convert basic AIKS golden tests to use DisplayList (flutter/engine#53969) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#151927) flutter/engine@d194a2f...00f0f6b 2024-07-17 [email protected] [Impeller] Convert basic AIKS golden tests to use DisplayList (flutter/engine#53969) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Converts several AIKS golden tests to use DisplayList as the mechanism.
In order to convert some of the tests, new factory methods were added to DlColor and tested with new unit tests (an earlier golden test conversion PR had a version of this as well).
Also, a new DisplayList record op was created for ClipOval to handle the AIKS clipping golden tests, but this new recording op is not used from Flutter
uicode (no plumbing to call it fromlib/ui/paintingor to convert any other DisplayList call to use the new record). An earlier attempt to add the new recording op caused a large number of golden changes upstream so this version will only be used for internal tests and support to use it from apps will follow in more targeted PRs to better manage golden changes. This PR should not result in any changes to goldens outside of internal engine tests.