This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] fix unexpected scrolling in semantics #53922
Merged
+59
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Jul 16, 2024
ditman
approved these changes
Jul 16, 2024
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM! with the nit of renaming the public-facing, focus method that behaves differently than on MDN.
yjbanov
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2024
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 17, 2024
…151863) flutter/engine@475980e...5b9fc4e 2024-07-16 [email protected] [iOS] Delete gen_snapshot_armv7 support (flutter/engine#53947) 2024-07-16 [email protected] Roll Skia from f9422e08a793 to d1478885de20 (3 revisions) (flutter/engine#53946) 2024-07-16 [email protected] [web] fix unexpected scrolling in semantics (flutter/engine#53922) 2024-07-16 [email protected] More logs for Android unsatisfiedLinkError (flutter/engine#53920) 2024-07-16 [email protected] Roll Skia from 9b789b35e109 to f9422e08a793 (1 revision) (flutter/engine#53944) 2024-07-16 [email protected] Roll Fuchsia Linux SDK from VlZIUknh6dnA23owe... to C_ze_BbJWtfB9GdOA... (flutter/engine#53941) 2024-07-16 [email protected] Roll Skia from a6ac2f8e82b4 to 9b789b35e109 (1 revision) (flutter/engine#53942) 2024-07-16 [email protected] Roll Skia from 57ae89c0ffae to a6ac2f8e82b4 (1 revision) (flutter/engine#53940) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from VlZIUknh6dnA to C_ze_BbJWtfB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#151863) flutter/engine@475980e...5b9fc4e 2024-07-16 [email protected] [iOS] Delete gen_snapshot_armv7 support (flutter/engine#53947) 2024-07-16 [email protected] Roll Skia from f9422e08a793 to d1478885de20 (3 revisions) (flutter/engine#53946) 2024-07-16 [email protected] [web] fix unexpected scrolling in semantics (flutter/engine#53922) 2024-07-16 [email protected] More logs for Android unsatisfiedLinkError (flutter/engine#53920) 2024-07-16 [email protected] Roll Skia from 9b789b35e109 to f9422e08a793 (1 revision) (flutter/engine#53944) 2024-07-16 [email protected] Roll Fuchsia Linux SDK from VlZIUknh6dnA23owe... to C_ze_BbJWtfB9GdOA... (flutter/engine#53941) 2024-07-16 [email protected] Roll Skia from a6ac2f8e82b4 to 9b789b35e109 (1 revision) (flutter/engine#53942) 2024-07-16 [email protected] Roll Skia from 57ae89c0ffae to a6ac2f8e82b4 (1 revision) (flutter/engine#53940) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from VlZIUknh6dnA to C_ze_BbJWtfB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#151863) flutter/engine@475980e...5b9fc4e 2024-07-16 [email protected] [iOS] Delete gen_snapshot_armv7 support (flutter/engine#53947) 2024-07-16 [email protected] Roll Skia from f9422e08a793 to d1478885de20 (3 revisions) (flutter/engine#53946) 2024-07-16 [email protected] [web] fix unexpected scrolling in semantics (flutter/engine#53922) 2024-07-16 [email protected] More logs for Android unsatisfiedLinkError (flutter/engine#53920) 2024-07-16 [email protected] Roll Skia from 9b789b35e109 to f9422e08a793 (1 revision) (flutter/engine#53944) 2024-07-16 [email protected] Roll Fuchsia Linux SDK from VlZIUknh6dnA23owe... to C_ze_BbJWtfB9GdOA... (flutter/engine#53941) 2024-07-16 [email protected] Roll Skia from a6ac2f8e82b4 to 9b789b35e109 (1 revision) (flutter/engine#53942) 2024-07-16 [email protected] Roll Skia from 57ae89c0ffae to a6ac2f8e82b4 (1 revision) (flutter/engine#53940) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from VlZIUknh6dnA to C_ze_BbJWtfB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always mark scrollable containers with
role="group"to prevent the browser from merging all child elements into one giant string. Default topreventScrollto true across the web engine code, because it's a better default for Flutter than otherwise.Fixes flutter/flutter#130950