This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[skia] Use more GNI file lists #53685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Jul 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 2, 2024
…151186) flutter/engine@433d360...4427894 2024-07-02 [email protected] Roll Skia from 42fad315c162 to c0ee0e108900 (1 revision) (flutter/engine#53691) 2024-07-02 [email protected] Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus" (flutter/engine#53679) 2024-07-02 [email protected] [skia] Use more GNI file lists (flutter/engine#53685) 2024-07-02 [email protected] Roll Skia from 7f2094d4cf43 to 42fad315c162 (1 revision) (flutter/engine#53684) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
hubot
pushed a commit
to google/skia
that referenced
this pull request
Jul 2, 2024
Follow-up to http://review.skia.org/862416 Client CLs: - https://crrev.com/c/5598447 - flutter/engine#53685 Change-Id: I7f98fb7decf819620e0c298f3f5f62830828e7e7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/871744 Commit-Queue: Kaylee Lubick <[email protected]> Reviewed-by: Ben Wagner <[email protected]>
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
…lutter#151186) flutter/engine@433d360...4427894 2024-07-02 [email protected] Roll Skia from 42fad315c162 to c0ee0e108900 (1 revision) (flutter/engine#53691) 2024-07-02 [email protected] Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus" (flutter/engine#53679) 2024-07-02 [email protected] [skia] Use more GNI file lists (flutter/engine#53685) 2024-07-02 [email protected] Roll Skia from 7f2094d4cf43 to 42fad315c162 (1 revision) (flutter/engine#53684) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In http://review.skia.org/862177 (and to a lesser extent, http://review.skia.org/862416), Skia added more .gni file lists for code in src/ports. This updates Flutter to use those lists instead of hard-coding those file paths directly, making it easier for upstream changes in Skia (e.g. file renames or relocations) to be pulled into Flutter without a Flutter-side change.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.