This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Restore creation of engine before Linux widget is realized. #53604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the changes in 9463b5d we were now taking two weak references using different methods. A later change showed reference errors in the tests, which seem to be solved by removing this change. Instead use a private shutdown method, which is clearer in any case.
This is for consistency with the other weak references. The newer API is thread safe.
Due to changes in the renderer in 6b857de the engine was created once a widget is realized, not when the widget is created. If a Flutter application changed the default my_application.cc template to show the Flutter widget after plugins are run then these plugins would not be able to access the engine. Solved by removing the GdkWindow from the renderer constructor and setting in later when the widget is realized. This works because the renderer is not used until the widget is realized. Fixes flutter/flutter#144873
Contributor
Author
|
Note this change also includes fixes for the weak reference handling which were causing the tests to crash after this change. This change should not be squashed so these commits are separate from the fix. |
Contributor
Author
|
@spydon please confirm if this fixes the issue for you. |
Member
|
Kicked the failing mac bot. Looked like a Metal related flake unrelated to your change. |
spydon
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Lgtm! Tried it on our the installer and the app center and it works with the plugins.
We still have the (most likely unrelated) issue where the start-up screen is black:
Screencast from 2024-07-01 14-56-54.webm
EDIT: The above only happens in debug mode
Opened flutter/flutter#151098 for that issue
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 2, 2024
…151156) flutter/engine@d3c5bd6...40c087b 2024-07-02 [email protected] Restore creation of engine before Linux widget is realized. (flutter/engine#53604) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
sigurdm
pushed a commit
to sigurdm/flutter
that referenced
this pull request
Jul 2, 2024
…lutter#151156) flutter/engine@d3c5bd6...40c087b 2024-07-02 [email protected] Restore creation of engine before Linux widget is realized. (flutter/engine#53604) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
…lutter#151156) flutter/engine@d3c5bd6...40c087b 2024-07-02 [email protected] Restore creation of engine before Linux widget is realized. (flutter/engine#53604) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
I had thought this would be cherry-picked for a hotfix, but it still seems broken today with Flutter 3.22.3 - is the fix only available in |
Contributor
Author
robert-ancell
added
the
cp: stable
Contributor
Author
|
Great, proposing for a cherry pick. |
|
Failed to create CP due to merge conflicts. |
Contributor
Author
|
This is now in 3.24, I won't propose it for 3.22 unless there is a need. |
|
Excellent! Thank you for all your hard work! 🙇♀️ I appreciate you 💙 😁 |
4 tasks
|
Thank you very much... it was very important. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in the renderer in 6b857de the engine was created once a widget is realized, not when the widget is created. If a Flutter application changed the default my_application.cc template to show the Flutter widget after plugins are run then these plugins would not be able to access the engine.
Solved by removing the GdkWindow from the renderer constructor and setting in later when the widget is realized. This works because the renderer is not used until the widget is realized.
Fixes flutter/flutter#144873