This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Return a null image from ImageExternalTextureGL::CreateEGLImage if an EGL display is not available #53594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… EGL display is not available Previously CreateEGLImage had been failing an assertion if an EGL display is not active on the calling thread. CreateEGLImage should not assert here because it could be called from a deferred task that runs after the raster thread has lost its EGL state. See flutter/flutter#149396
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
approved these changes
Jun 26, 2024
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
If we have any existing tests, could we test this by calling CreateEGLImage before setting up the EGL context?
Member
Author
|
AFAICT there is no unit test harness that directly invokes the Android embedder's I tested this manually by running a platform view example app with |
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2024
…mage if an EGL display is not available (flutter/engine#53594)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 27, 2024
…150888) flutter/engine@1d5e3cc...a9194f0 2024-06-26 [email protected] Roll Skia from 173ee0af82c9 to 55ada83438cd (3 revisions) (flutter/engine#53596) 2024-06-26 [email protected] Return a null image from ImageExternalTextureGL::CreateEGLImage if an EGL display is not available (flutter/engine#53594) 2024-06-26 [email protected] [Impeller] blur - cropped the downsample pass for backdrop filters (flutter/engine#53562) 2024-06-26 [email protected] Roll Skia from 0a979d9f3606 to 173ee0af82c9 (2 revisions) (flutter/engine#53593) 2024-06-26 [email protected] Remove otherwise unused third_party/web_dependencies. (flutter/engine#53588) 2024-06-26 [email protected] Copy `flutter/flutter/docs/engine` to `flutter/engine/docs` as-is (no changes) (flutter/engine#53595) 2024-06-26 [email protected] Roll Dart SDK from 38bb74f63829 to c01f907d34d8 (5 revisions) (flutter/engine#53585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
…lutter#150888) flutter/engine@1d5e3cc...a9194f0 2024-06-26 [email protected] Roll Skia from 173ee0af82c9 to 55ada83438cd (3 revisions) (flutter/engine#53596) 2024-06-26 [email protected] Return a null image from ImageExternalTextureGL::CreateEGLImage if an EGL display is not available (flutter/engine#53594) 2024-06-26 [email protected] [Impeller] blur - cropped the downsample pass for backdrop filters (flutter/engine#53562) 2024-06-26 [email protected] Roll Skia from 0a979d9f3606 to 173ee0af82c9 (2 revisions) (flutter/engine#53593) 2024-06-26 [email protected] Remove otherwise unused third_party/web_dependencies. (flutter/engine#53588) 2024-06-26 [email protected] Copy `flutter/flutter/docs/engine` to `flutter/engine/docs` as-is (no changes) (flutter/engine#53595) 2024-06-26 [email protected] Roll Dart SDK from 38bb74f63829 to c01f907d34d8 (5 revisions) (flutter/engine#53585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously CreateEGLImage had been failing an assertion if an EGL display is not active on the calling thread. CreateEGLImage should not assert here because it could be called from a deferred task that runs after the raster thread has lost its EGL state.
See flutter/flutter#149396