Move //third_party/java to //flutter/third_party/java
#53590
Conversation
|
From Android triage: FYI, the last time resources were moved, Java linting failed silently. |
Sorry what does that mean? Don't land this? What linting? |
|
@reidbaker Any thoughts? Does our previous experience with migrating resources amount to anything more than an FYI here, or impact how this PR should move forward in any way? |
|
It means be on the lookout for weird behavior related to java. Tests passing is not a good indication of stability when it comes to moving the locations of resources. |
I don't think that kind of comment is very helpful, I can't possibly be on the lookout for behavior that isn't triggered on CI. Maybe what you're saying is "we would like to have more assurance Java linting is working/enforced on CI before landing this change", which is a reasonable request. By Java linting, I assume you mean If so I could add a CI check that intentionally makes a change that should be blocked, for example. Wdut? /cc @gaaclarke if you have any thoughts about the above. |
|
I'm unfamiliar with the linting problems of the past but I agree that we shouldn't accommodate any behavior that isn't tested on CI. I think intentionally introducing a linting exception that the linter catches it as part of the CI checks makes sense if this is something we want to make sure doesn't break in the future. |
|
I will wait to land this Monday, so there isn't engine breaks of LUCI cache weirdness over the weekend. |
matanlurey
force-pushed
the
move-android-jdk
branch
from
b54392e to
4467528
Compare
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/53590, due to - The status or check suite Linux linux_android_debug_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
The failures do look related. Perhaps you missed a spot where the paths need a fixup? |
Updated! |
…151678) flutter/engine@6b36113...63dd507 2024-07-12 [email protected] Relax the event assumptions for keydown events. (flutter/engine#53830) 2024-07-12 [email protected] Move `//third_party/java` to `//flutter/third_party/java` (flutter/engine#53590) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
6 participants
... as part of buildmoot.