This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Prepare engine for deprecation of async_minitest.dart #53560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dart SDK's `package:async_helper/async_minitest.dart` was never intended for new tests, it was a drop-in polyfill for the legacy `package:unit_test` that some Dart SDK tests were using. The tests should never have used that package, and migrating them to `package:test` was not an option, so the `async_minitest.dart` file was the minimal polyfill that made all the tests run. Since then, new tests have been written using the file, and to stop that, the file will now become deprecated, and (hopefully some day) removed. If the Flutter engine wants to keep using the file, they should own their own copy of it, which is what this change does. (Also migrate off the to-be-deprecated `assertStatementsEnabled` property of `package:expect/expect.dart`, moved to the new `asserts` from `package:expect/variations.dart`.)
| @@ -0,0 +1,338 @@ | |||
| // Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file | |||
Member
There was a problem hiding this comment.
This copyright header needs to be reassigned.
chinmaygarde
approved these changes
Jun 27, 2024
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Other than the note about copyright header blocker, lgtm.
jason-simmons
approved these changes
Jun 27, 2024
Update license text.
The source verification does not allow a file to exist and not be mentioned, not to not exist and be mentioned, so it will require an update of the script to eventually remove the file.
Contributor
Author
|
The Fuchsia builder's source-validation seems to insist that every file in a third-party package is listed in sources, |
Member
|
May I land this @lrhn ? |
Contributor
Author
|
Please do. |
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 12, 2024
…151690) flutter/engine@63dd507...1554a0d 2024-07-12 [email protected] Roll Dart SDK from e986ed9d0bc1 to b44d99ea2bf4 (1 revision) (flutter/engine#53846) 2024-07-12 [email protected] Prepare engine for deprecation of async_minitest.dart (flutter/engine#53560) 2024-07-12 [email protected] [Impeller] Refactor and document Android rendering related TUs. (flutter/engine#53802) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dart SDK's
package:async_helper/async_minitest.dartwas never intended for new tests, it was a drop-in polyfill for the legacypackage:unit_testthat some Dart SDK tests were using. The tests should never have used that package, and migrating them topackage:testwas not an option, so theasync_minitest.dartfile was the minimal polyfill that made all the tests run.Since then, new tests have been written using the file, and to stop that, the file will now become deprecated, and (hopefully some day) removed.
If the Flutter engine wants to keep using the file, they should own their own copy of it, which is what this change does.
(Also migrates off the to-be-deprecated
assertStatementsEnabledproperty ofpackage:expect/expect.dart, moved to the newassertsfrompackage:expect/variations.dart.)