This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove FlutterUndoManagerPlugin handlers from undo manager on dealloc #53553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Jun 25, 2024
| XCTAssertNil(weakUndoManagerPlugin); | ||
| // Regression test for https://github.com/flutter/flutter/issues/150408. | ||
| // Undo manager undo and redo stack should be empty after the plugin deallocs. | ||
| XCTAssertFalse(undoManager.canUndo); |
Member
Author
There was a problem hiding this comment.
This assert fails on main without this change (though I couldn't get it to actually crash):
FlutterUndoManagerPluginTest.mm:198: error: -[FlutterUndoManagerPluginTest testDeallocRemovesAllUndoManagerActions] : ((undoManager.canUndo) is false) failed
jmagman
changed the title
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 26, 2024
…150829) flutter/engine@25af762...da62c62 2024-06-26 [email protected] Roll Fuchsia Linux SDK from WUN7NQK04NjF9fRmf... to n2dgSmMCaCO7ujvmr... (flutter/engine#53575) 2024-06-25 [email protected] Remove FlutterUndoManagerPlugin handlers from undo manager on dealloc (flutter/engine#53553) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from WUN7NQK04NjF to n2dgSmMCaCO7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
@jmagman I'm a bit confused. According to the flutter/flutter#150408 description, if we set |
Member
Author
I don't understand your question, does flutter/flutter#150408 (comment) answer it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
FlutterUndoManagerPlugindeallocated, it is supposed to deregister itself from theNSUndoManagerstack.However, during dealloc
_undoManagerDelegate.undoManageris nil (_undoManagerDelegate= the engine, andundoManagerwas its view controller'sundoManager, which was already gone).Since
_undoManagerDelegate.undoManageris nil, it doesn't actually call-[NSUndoManager removeAllActionsWithTarget]. In the add-to-app scenario, after the view controller pops back to the native view, and "undo" is invoked, the undo action for theFlutterUndoManagerPluginis handled, but it already dealloced so crash.Fixes flutter/flutter#150408
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.