Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jun 20, 2024

#53402 didn't work. Run these Safari tests on macOS 13 only until it can be fixed for macOS 14.

@jmagman jmagman self-assigned this Jun 20, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 20, 2024
@jmagman
Copy link
Member Author

jmagman commented Jun 20, 2024

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 21, 2024

auto label is removed for flutter/engine/53497, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2024
@auto-submit auto-submit bot merged commit c26977e into flutter:main Jun 21, 2024
@jmagman jmagman deleted the web-mac branch June 21, 2024 20:52
@jmagman
Copy link
Member Author

jmagman commented Jun 21, 2024

auto label is removed for flutter/engine/53497, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

Filed flutter/flutter#150640

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 22, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants