This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Move drawAtlas golden tests to display list. #53398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
gaaclarke
approved these changes
Jun 14, 2024
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
LGTM, I think parameter comments would help reading the tests but they weren't there before so no requirement to add them.
|
|
||
| builder.Scale(GetContentScale().x, GetContentScale().y); | ||
| builder.DrawAtlas(atlas, transforms.data(), texture_coordinates.data(), | ||
| nullptr, 4, DlBlendMode::kSrcOver, |
Member
There was a problem hiding this comment.
Suggested change
| nullptr, 4, DlBlendMode::kSrcOver, | |
| /*colors=*/nullptr, /*count=*/4, DlBlendMode::kSrcOver, |
| builder.Scale(GetContentScale().x, GetContentScale().y); | ||
| builder.DrawAtlas(atlas, transforms.data(), texture_coordinates.data(), | ||
| nullptr, 4, DlBlendMode::kSrcOver, | ||
| DlImageSampling::kNearestNeighbor, nullptr); |
Member
There was a problem hiding this comment.
Suggested change
| DlImageSampling::kNearestNeighbor, nullptr); | |
| DlImageSampling::kNearestNeighbor, /*cullRect=*/nullptr); |
| auto size = atlas->impeller_texture()->GetSize(); | ||
| std::vector<SkRect> texture_coordinates = { | ||
| SkRect::MakeLTRB(0, 0, size.width, size.height)}; | ||
| std::vector<SkRSXform> transforms = {MakeTranslation(0, 0)}; |
Member
There was a problem hiding this comment.
No action required: "SkRSXform", really skia?
Member
|
Goldens look reasonable to me too, nothing was obviously broken to me. |
|
Golden file changes are available for triage from new commit, Click here to view. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 18, 2024
…150399) flutter/engine@a4f266f...1c4e5e2 2024-06-17 [email protected] [DisplayList] Create DrawDashedLine for paragraph code (flutter/engine#53411) 2024-06-17 [email protected] [Impeller] Update Android CPU profiling instructions. (flutter/engine#53437) 2024-06-17 [email protected] [Impeller] move draw vertices to dl unittests. (flutter/engine#53400) 2024-06-17 [email protected] [Impeller] Link CPU profiling docs from the main README. (flutter/engine#53435) 2024-06-17 [email protected] Roll Dart SDK from 1ce6b4d54247 to 51bbba0da7d3 (1 revision) (flutter/engine#53432) 2024-06-17 [email protected] [Impeller] Move drawAtlas golden tests to display list. (flutter/engine#53398) 2024-06-17 [email protected] [flatland] Handle fence overflow in flatland_connection.cc (flutter/engine#53366) 2024-06-17 [email protected] Roll Skia from 0dda1054f543 to 2b9bc16df969 (1 revision) (flutter/engine#53431) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#142054
Moves all of the drawAtlas tests for aiks and entities into DL. This might change some of the entity goldens but ... these are easy to eyeball so it should be fine IMO.