Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@vashworth
Copy link
Contributor

In preparation of upgrading our fleet to macOS 14, allow tests to run on either macOS 13 or 14.

Fixes flutter/flutter#148879.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Jun 6, 2024
@vashworth vashworth marked this pull request as ready for review June 6, 2024 16:50
@vashworth vashworth requested a review from jmagman June 6, 2024 16:50
// https://github.com/flutter/flutter/issues/136274,
// https://github.com/flutter/flutter/issues/136279
..._getTestStepsForPlatform(suites, 'Mac', specificOS: 'Mac-13', cpu: 'arm64', (TestSuite suite) =>
..._getTestStepsForPlatform(suites, 'Mac', specificOS: 'Mac-13|Mac-14', cpu: 'arm64', (TestSuite suite) =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this file generates ci/builders/linux_web_engine.json

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2024
@auto-submit auto-submit bot merged commit 31804a2 into flutter:main Jun 6, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 6, 2024
…149837)

flutter/engine@25bcbb8...31804a2

2024-06-06 [email protected] Run tests on macOS 13 or 14 (flutter/engine#53252)
2024-06-06 [email protected] Roll Skia from d5acbe6bb22d to 1211df22d135 (2 revisions) (flutter/engine#53255)
2024-06-06 [email protected] Roll Fuchsia Linux SDK from 2xWubo2mRP_2_wXKJ... to aVohW_hnfDaE0smBX... (flutter/engine#53253)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 2xWubo2mRP_2 to aVohW_hnfDaE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update .ci.yaml and configs in flutter/engine to use either macOS 13 or macOS 14

2 participants