This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[DisplayList] remove legacy DisplayListMatrixClipTracker #53232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Requesting a look from @knopp as the changes to DiffContext were probably the least "1:1 straightforward". |
flar
commented
Jun 5, 2024
|
|
||
| DisplayListMatrixClipTracker state1(cull_rect, SkMatrix::I()); | ||
| DisplayListMatrixClipTracker state2(dl_cull_rect, DlMatrix()); | ||
| DisplayListMatrixClipState state1(cull_rect, SkMatrix::I()); |
Contributor
Author
There was a problem hiding this comment.
Ooops, back when I split the State and Tracker classes and duplicated all of the unit tests, this one "allegedly State" test was still "duplicatively" testing the Tracker instead of the State class due to forgetting to change the class name... D'oh!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2024
…149785) flutter/engine@f51e0ad...0edca2e 2024-06-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Use Skia software renderer to draw stroked text. (#53198)" (flutter/engine#53237) 2024-06-05 [email protected] [Impeller] Use Skia software renderer to draw stroked text. (flutter/engine#53198) 2024-06-05 [email protected] Remove the DBC interpreter flag. (flutter/engine#53204) 2024-06-05 [email protected] [web] Adds allowPlatformDefault for wheel signals. (flutter/engine#51566) 2024-06-05 [email protected] [Impeller] fix emojis with non-solid color sources. (flutter/engine#53229) 2024-06-05 [email protected] Roll Skia from 8448abc95867 to 89570a0a171e (1 revision) (flutter/engine#53236) 2024-06-05 [email protected] Roll Dart SDK from f838a9a8d45f to 86b8aacb2609 (1 revision) (flutter/engine#53234) 2024-06-05 [email protected] [DisplayList] remove legacy DisplayListMatrixClipTracker (flutter/engine#53232) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MatrixClipTracker was nothing more than a vector of MatrixClipState objects and a whole lot of duplicate delegation methods. It provided little value since nearly every use of it already had a state stack that was kept in synch with it's internal stack and so it was just adding an extra layer of delegation and extra allocations.