[icu] Manual roll of icu #53199
[icu] Manual roll of icu #53199
Conversation
filmil
force-pushed
the
icu-jun-2024
branch
3 times, most recently
from
6ca995f to
f827858
Compare
The wording change in the license file in ICU 74.1 required adapting the license-recognizing regex pattern. This is why the roll is manual instead of automated. Similarly, changes in Unicode data files required expanding the allowlist of patterns which have spurious occurences of the "Copyright" symbol. Issue: flutter/flutter#149684
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@matanlurey Please review. (if all passes, I will also need you to merge this, as I'm not a committer.) |
|
Can you please merge this for me? I am not a committer. |
matanlurey
added
the
autosubmit
I've added |
…149770) flutter/engine@11a32d4...f377330 2024-06-05 [email protected] Roll Skia from 37755d48cca3 to 8448abc95867 (7 revisions) (flutter/engine#53230) 2024-06-05 [email protected] Roll Dart SDK from dac7c04c7342 to f838a9a8d45f (3 revisions) (flutter/engine#53225) 2024-06-05 [email protected] Roll Skia from 337c3c4d1f1b to 37755d48cca3 (45 revisions) (flutter/engine#53224) 2024-06-05 [email protected] [web] enable always_specify_types for web_ui (flutter/engine#53226) 2024-06-05 [email protected] Re-land #52859: Revamp the engine style guide, remove `always_specify_types` (flutter/engine#53223) 2024-06-05 [email protected] Roll Fuchsia Linux SDK from pagJoGS4kQ8Efa_if... to 2xWubo2mRP_2_wXKJ... (flutter/engine#53222) 2024-06-05 [email protected] [icu] Manual roll of icu (flutter/engine#53199) 2024-06-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering (#53072)" (flutter/engine#53220) 2024-06-05 [email protected] [ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering (flutter/engine#53072) 2024-06-05 [email protected] Roll Dart SDK from 343c20614708 to dac7c04c7342 (1 revision) (flutter/engine#53209) 2024-06-04 [email protected] [Impeller] Intel iOS Simulators must block on GPU completion. (flutter/engine#53073) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from pagJoGS4kQ8E to 2xWubo2mRP_2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
The changes here seem to be causing license headers to fail to be identified. See license compliance presubmit result here: cl/641003589. Can this be rolled back? EDIT: Wait, this might not be related to the issue we're seeing. Still investigating. |
Isn't this something that should be fixed downstream? |
|
To wit, ICU license did change in ICU release So if downstream indeed has a rigid dependency on the ICU license not changing, well, then that check will need to be adapted. |
|
@filmil I've engaged Christian in an internal chat - I also don't understand what we expect y'all to have done differently. I'll come back here if we need any changes (unlikely) |
If I may venture a guess, I think downstream made a reasonable assumption that the upstream license wouldn't change. But it did.
|
|
LOL. Thank you for that bit of humor :) |
|
The change was approved internally, no action required. |
4 participants
Manual roll of the ICU library. This normally happens automatically, but this
time around, ICU folks changed their license, so that needs to be fixed up.
I wish they would stop doing that. :)
This manual change should enable us to turn the auto-roller back on.
flutter/flutter#149684
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.