[Impeller] Revert support for multi-arch shader archives. #53158
Conversation
|
We'll still need this when/if we do GLES on Android. Does backing it out save us any work? |
|
When we do GLES on Android, we can package the shaders in separately like we do for Vulkan. For instance, |
|
but this is for RuntimeEffect, where the shader is bundled in a framework asset. This is definitely getting used right now, in fact. |
|
Are you thinking of the runtime stage types? Those are different from this multi-arch stuff. |
|
Ahh okay, got those wires crossed in my head. |
chinmaygarde
added
the
autosubmit
…149468) flutter/engine@b0f4d74...d81edf6 2024-06-01 [email protected] [Impeller] Revert support for multi-arch shader archives. (flutter/engine#53158) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
This was never fully wired up and we never ended up needing this as there is only still on backend per platform. Earlier, we expected to have both GLES and Vulkan on Android.
Reverts 2251b87 and 502755d with fixups.