[Impeller] wire up bdf and blend detection in experimental canvas. #53151
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
changed the title
flar
left a comment
flar
left a comment
There was a problem hiding this comment.
LGTM! Note suggestion about blend constants...
| const ContentContext& renderer, | ||
| flutter::DlBlendMode max_root_blend_mode) { | ||
| return !renderer.GetDeviceCapabilities().SupportsFramebufferFetch() && | ||
| max_root_blend_mode >= flutter::DlBlendMode::kScreen; |
There was a problem hiding this comment.
Is there a kLastSomethingBlendMode constant in Impeller's blend mode? If this method took an impeller blend mode it could use that for this test. DlBlendMode currently has a different set of "cutoff constants", though.
Just thinking forward until someone fixes the "is screen an advanced blend mode" issue.
There was a problem hiding this comment.
Oh right, good idea!
jonahwilliams
changed the title
jonahwilliams
added
the
autosubmit
…149695) flutter/engine@3dd4015...e884690 2024-06-04 [email protected] [Impeller] Clarify rendering backend fallback behavior on Android. (flutter/engine#53202) 2024-06-04 [email protected] [Impeller] wire up bdf and blend detection in experimental canvas. (flutter/engine#53151) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Use the flags in #53104 + context capabilities to determine if we need to begin the first pass as an offscreen.
Part of flutter/flutter#142054