Remove complexity calculator with Slimpeller #53140
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| GrBackendApi backend) { | ||
| switch (backend) { | ||
| case GrBackendApi::kMetal: | ||
| #if !SLIMPELLER |
There was a problem hiding this comment.
I've also resorted to putting giant if !SLIMPELLER guards around the header and the implementation for good measure. That way, unknown uses are shaken out and the stuff isn't even compiled in.
jonahwilliams
added
the
autosubmit
…149447) flutter/engine@fa30658...1814031 2024-05-31 [email protected] Remove SK_RESOLVE_FILTERS_BEFORE_RESTORE flag (flutter/engine#49563) 2024-05-31 [email protected] Remove complexity calculator with Slimpeller (flutter/engine#53140) 2024-05-31 [email protected] Roll Skia from 208469d270b7 to f1f13534b0c2 (1 revision) (flutter/engine#53152) 2024-05-31 [email protected] Roll Skia from ce975ddfd9fb to 208469d270b7 (1 revision) (flutter/engine#53150) 2024-05-31 [email protected] Google java format relocation and formatting update (flutter/engine#53118) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Will it blend?