This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Migrate off deprecated GrVkBackendContext fields #53122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also had one of Skia's Vulkan experts look at the changes to make sure I handled the extensions correctly. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 3, 2024
…149623) flutter/engine@ea72558...60a7bb2 2024-06-03 [email protected] [Impeller] fix NPE caused by implicit sk_sp to fml::Status conversion. (flutter/engine#53177) 2024-06-03 [email protected] Migrate off deprecated GrVkBackendContext fields (flutter/engine#53122) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
hubot
pushed a commit
to google/skia
that referenced
this pull request
Jun 5, 2024
This incidentally fixes an issue where if clients provided a non-null fDeviceFeatures but a null extensions, Skia could dereference a null pointer (in Ganesh). Client CLs: - flutter/engine#53122 Bug: b/309785258 Change-Id: I0af32b5e47ac65e882271eb9b75b036b82c6371e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/859517 Reviewed-by: Robert Phillips <[email protected]> Reviewed-by: Nicolette Prevost <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://g-issues.skia.org/issues/309785258
Skia would like to remove these deprecated fields, so this updates Flutter's use of them to use the new ways.
Note that
VulkanWindowseems to be unused (or no longer used?) since there was a mistyped define (SK_VUKLAN->SK_VULKAN) causing the code I am fixing to never be run.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.