This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] revert changes to IO thread upload scheduling. #53096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
May 29, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2024
…149290) flutter/engine@8d5d14a...4adf453 2024-05-29 [email protected] Roll Skia from aecf76e8eb9a to f23183f041fe (1 revision) (flutter/engine#53102) 2024-05-29 [email protected] Update CONTRIBUTING.md links (flutter/engine#53043) 2024-05-29 [email protected] Roll Skia from 32746679f7be to aecf76e8eb9a (1 revision) (flutter/engine#53100) 2024-05-29 [email protected] Roll Skia from b18b7d6af6e8 to 32746679f7be (2 revisions) (flutter/engine#53097) 2024-05-29 [email protected] [Impeller] revert changes to IO thread upload scheduling. (flutter/engine#53096) 2024-05-29 [email protected] [Impeller] fix barriers prior to mip generation. (flutter/engine#53082) 2024-05-29 [email protected] Roll Skia from e11a5c5b402e to b18b7d6af6e8 (2 revisions) (flutter/engine#53095) 2024-05-29 [email protected] Switch to FilterQuality.medium for images (flutter/engine#52984) 2024-05-29 [email protected] Roll Skia from a4f58c9dabc3 to e11a5c5b402e (1 revision) (flutter/engine#53092) 2024-05-29 [email protected] Roll Skia from ca77972f659e to a4f58c9dabc3 (2 revisions) (flutter/engine#53091) 2024-05-29 [email protected] [Impeller] relax conditions for SkRRect.isSimple conversion to impeller::RRect. (flutter/engine#53083) 2024-05-29 [email protected] Roll Skia from d1a6967c48a5 to ca77972f659e (1 revision) (flutter/engine#53090) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#149290) flutter/engine@8d5d14a...4adf453 2024-05-29 [email protected] Roll Skia from aecf76e8eb9a to f23183f041fe (1 revision) (flutter/engine#53102) 2024-05-29 [email protected] Update CONTRIBUTING.md links (flutter/engine#53043) 2024-05-29 [email protected] Roll Skia from 32746679f7be to aecf76e8eb9a (1 revision) (flutter/engine#53100) 2024-05-29 [email protected] Roll Skia from b18b7d6af6e8 to 32746679f7be (2 revisions) (flutter/engine#53097) 2024-05-29 [email protected] [Impeller] revert changes to IO thread upload scheduling. (flutter/engine#53096) 2024-05-29 [email protected] [Impeller] fix barriers prior to mip generation. (flutter/engine#53082) 2024-05-29 [email protected] Roll Skia from e11a5c5b402e to b18b7d6af6e8 (2 revisions) (flutter/engine#53095) 2024-05-29 [email protected] Switch to FilterQuality.medium for images (flutter/engine#52984) 2024-05-29 [email protected] Roll Skia from a4f58c9dabc3 to e11a5c5b402e (1 revision) (flutter/engine#53092) 2024-05-29 [email protected] Roll Skia from ca77972f659e to a4f58c9dabc3 (2 revisions) (flutter/engine#53091) 2024-05-29 [email protected] [Impeller] relax conditions for SkRRect.isSimple conversion to impeller::RRect. (flutter/engine#53083) 2024-05-29 [email protected] Roll Skia from d1a6967c48a5 to ca77972f659e (1 revision) (flutter/engine#53090) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#147429
Turns out we need the I/O thread for all backends still to limit uploads otherwise we compete with the raster thread.