This repository was archived by the owner on Feb 25, 2025. It is now read-only.
DisplayList forward opacity incompatibility through deferred saves #53078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 29, 2024
…149249) flutter/engine@b26e1b0...30aa720 2024-05-29 [email protected] Roll Skia from 99966843c23f to 2fe794827c51 (1 revision) (flutter/engine#53087) 2024-05-29 [email protected] Roll Skia from d2469aaf5ab1 to 99966843c23f (1 revision) (flutter/engine#53086) 2024-05-29 [email protected] Roll Skia from 9ea5a1dd5270 to d2469aaf5ab1 (2 revisions) (flutter/engine#53085) 2024-05-29 [email protected] Roll Skia from eedef8763102 to 9ea5a1dd5270 (1 revision) (flutter/engine#53084) 2024-05-29 [email protected] Roll Skia from 0026a6047133 to eedef8763102 (1 revision) (flutter/engine#53081) 2024-05-29 [email protected] DisplayList forward opacity incompatibility through deferred saves (flutter/engine#53078) 2024-05-28 [email protected] Roll Skia from ac454b80130c to 0026a6047133 (1 revision) (flutter/engine#53076) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#149249) flutter/engine@b26e1b0...30aa720 2024-05-29 [email protected] Roll Skia from 99966843c23f to 2fe794827c51 (1 revision) (flutter/engine#53087) 2024-05-29 [email protected] Roll Skia from d2469aaf5ab1 to 99966843c23f (1 revision) (flutter/engine#53086) 2024-05-29 [email protected] Roll Skia from 9ea5a1dd5270 to d2469aaf5ab1 (2 revisions) (flutter/engine#53085) 2024-05-29 [email protected] Roll Skia from eedef8763102 to 9ea5a1dd5270 (1 revision) (flutter/engine#53084) 2024-05-29 [email protected] Roll Skia from 0026a6047133 to eedef8763102 (1 revision) (flutter/engine#53081) 2024-05-29 [email protected] DisplayList forward opacity incompatibility through deferred saves (flutter/engine#53078) 2024-05-28 [email protected] Roll Skia from ac454b80130c to 0026a6047133 (1 revision) (flutter/engine#53076) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous reorg of the DisplayListBuilder save/restore code placed the code that forwards layer flags inside the code that processes a non-deferred save call, but it needs to be processed regardless of the deferred save.