This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[canvaskit] Fix overlay reorganization for edge case with only 1 overlay #53006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
approved these changes
May 23, 2024
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
If I understood this correctly, this will add picturesForLastCanvas when in the last canvas, OR when the engine is set to have 1 max canvas. If so, ship!
harryterkelsen
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/53006, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
harryterkelsen
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 25, 2024
…149057) flutter/engine@b5e98f9...f693fdd 2024-05-24 [email protected] [canvaskit] Fix overlay reorganization for edge case with only 1 overlay (flutter/engine#53006) 2024-05-24 [email protected] Roll Dart SDK from 49b226cecee7 to 4ef8ed68a8d4 (1 revision) (flutter/engine#53024) 2024-05-24 [email protected] Roll Skia from f832549400ab to 97783ac3000d (1 revision) (flutter/engine#53023) 2024-05-24 [email protected] [Impeller] sped up the linear gradient by moving calculations to the cpu (flutter/engine#53007) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#149057) flutter/engine@b5e98f9...f693fdd 2024-05-24 [email protected] [canvaskit] Fix overlay reorganization for edge case with only 1 overlay (flutter/engine#53006) 2024-05-24 [email protected] Roll Dart SDK from 49b226cecee7 to 4ef8ed68a8d4 (1 revision) (flutter/engine#53024) 2024-05-24 [email protected] Roll Skia from f832549400ab to 97783ac3000d (1 revision) (flutter/engine#53023) 2024-05-24 [email protected] [Impeller] sped up the linear gradient by moving calculations to the cpu (flutter/engine#53007) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is only 1 overlay, move pictures in the reduced rendering to the last canvas instead of the second-to-last.
Fixes a bug in #51397
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.