This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix stroke curves. #52978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
Author
|
This should cause some of the tests to fail. Going to update them once they do. : ) |
bdero
force-pushed
the
bdero/fix-stroke-curves
branch
from
1965f9b to
bca2a4b
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jason-simmons
approved these changes
May 22, 2024
Member
|
Does this also resolve flutter/flutter#148323? |
Member
|
I eyeballed the pending goldens and they look right to me. woot. |
Member
Author
|
Well this is way better captured by the goldens than I was anticipating. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2024
…148950) flutter/engine@964f087...2a48302 2024-05-23 [email protected] [Impeller] Fix stroke curves. (flutter/engine#52978) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
|
We should discuss cherry picking this. I've added a prompt to the weekly. |
This was referenced May 25, 2024
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#148950) flutter/engine@964f087...2a48302 2024-05-23 [email protected] [Impeller] Fix stroke curves. (flutter/engine#52978) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
pushed a commit
to jonahwilliams/engine
that referenced
this pull request
Jun 5, 2024
Resolves flutter/flutter#147139. Added an explanation inline for why we need to use different direction values depending on whether or not we're capping off the last component of the contour. Before: <img width="640" alt="Screenshot 2024-05-21 at 11 18 51�PM" src="https://github.com/flutter/engine/assets/919017/22d9fee7-834f-4cb4-8ed4-578a7c17f7a2"> <img width="121" alt="Screenshot 2024-05-21 at 11 19 35�PM" src="https://github.com/flutter/engine/assets/919017/419029b1-9a5f-4a30-bbb0-83dafc79f7df"> After: <img width="640" alt="Screenshot 2024-05-21 at 11 17 25�PM" src="https://github.com/flutter/engine/assets/919017/629e30a5-d0c5-4b7a-a3e2-bf715aa4ba78"> <img width="115" alt="Screenshot 2024-05-21 at 11 16 38�PM" src="https://github.com/flutter/engine/assets/919017/12e51892-6009-47d0-a4e5-1f1b017c99e8">
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
Resolves flutter/flutter#147139. Added an explanation inline for why we need to use different direction values depending on whether or not we're capping off the last component of the contour. Before: <img width="640" alt="Screenshot 2024-05-21 at 11 18 51�PM" src="https://github.com/flutter/engine/assets/919017/22d9fee7-834f-4cb4-8ed4-578a7c17f7a2"> <img width="121" alt="Screenshot 2024-05-21 at 11 19 35�PM" src="https://github.com/flutter/engine/assets/919017/419029b1-9a5f-4a30-bbb0-83dafc79f7df"> After: <img width="640" alt="Screenshot 2024-05-21 at 11 17 25�PM" src="https://github.com/flutter/engine/assets/919017/629e30a5-d0c5-4b7a-a3e2-bf715aa4ba78"> <img width="115" alt="Screenshot 2024-05-21 at 11 16 38�PM" src="https://github.com/flutter/engine/assets/919017/12e51892-6009-47d0-a4e5-1f1b017c99e8">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#147139.
Added an explanation inline for why we need to use different direction values depending on whether or not we're capping off the last component of the contour.
Before:
After:
