This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Adds Noto Serif Tibetan fallback font. #52971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
Added test for this specific fallback font. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 22, 2024
…148819) flutter/engine@c89defa...b6971cd 2024-05-22 [email protected] Roll Fuchsia Linux SDK from HHwlAJN5imwf3yX4i... to gWBn6yPljFeQvPSYz... (flutter/engine#52975) 2024-05-22 [email protected] [Impeller] Round out subpass coverage. (flutter/engine#52973) 2024-05-22 [email protected] Roll Skia from 968e971e438e to 78069713e02a (1 revision) (flutter/engine#52974) 2024-05-21 [email protected] Roll Dart SDK from f0ac30bbc63e to fca7dd796e81 (1 revision) (flutter/engine#52972) 2024-05-21 [email protected] [web] Adds Noto Serif Tibetan fallback font. (flutter/engine#52971) 2024-05-21 [email protected] Update file permissions for FlutterMacOS.framework bundle (flutter/engine#52961) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from HHwlAJN5imwf to gWBn6yPljFeQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#148819) flutter/engine@c89defa...b6971cd 2024-05-22 [email protected] Roll Fuchsia Linux SDK from HHwlAJN5imwf3yX4i... to gWBn6yPljFeQvPSYz... (flutter/engine#52975) 2024-05-22 [email protected] [Impeller] Round out subpass coverage. (flutter/engine#52973) 2024-05-22 [email protected] Roll Skia from 968e971e438e to 78069713e02a (1 revision) (flutter/engine#52974) 2024-05-21 [email protected] Roll Dart SDK from f0ac30bbc63e to fca7dd796e81 (1 revision) (flutter/engine#52972) 2024-05-21 [email protected] [web] Adds Noto Serif Tibetan fallback font. (flutter/engine#52971) 2024-05-21 [email protected] Update file permissions for FlutterMacOS.framework bundle (flutter/engine#52961) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from HHwlAJN5imwf to gWBn6yPljFeQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "Noto Serif Tibetan" fallback font to Flutter Web, so it can render Dzongkha, and other languages in Tibetan script.
(In order to add this fallback font, an automated script is run which updates the versions and glyphs of other fallback fonts at the same time)
(Bundle uploaded to CIPD)
Issues
Testing
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.