Re-add `MipFilter::kBase`, but keep `kNearest` as the default. #52779

matanlurey · 2024-05-13T21:51:30Z

Changes:

Make sure the default of kNearest is used consistently
Partial revert of [Impeller] Remove MipFilter::kNone redux #40491, re-adding kBase
Added some documentation about relevant enums, and why the default is kNearest
Wired up kBase in the Metal, Vulkan, and OpenGLES backends

Expecting an update to the dart_ui_filter_quality_none golden file:

For breadcrumbs around the mapping, see flutter/flutter#148253.

jonahwilliams · 2024-05-13T21:54:31Z

impeller/renderer/backend/gles/sampler_gles.cc

-
-  switch (mip_filter.value()) {
+                     MipFilter mip_filter = MipFilter::kNearest) {
+  switch (mip_filter) {


@chinmaygarde to confirm, I think I remember this being weird because I had to fake support no mips.

I suspect we still need to treat an unspecified param as kBase here

PTAL again, made some adjustments

looks good to me

jonahwilliams · 2024-05-13T21:55:09Z

impeller/entity/contents/text_contents.cc

+  // `MipFilter::kNearest` is the default value for mip filters, as it
+  // cooresponds with the framework's `FilterQuality.low`. If we ever change the
+  // default filter quality, we should update this function to match.
  sampler_desc.mip_filter = MipFilter::kNearest;


Its probably correct for this to be changed to base since we don't generate mipmaps for glyph atlas (as they glyphs are generated at exact scales)

jonahwilliams

LGTM

flutter-dashboard · 2024-05-13T23:24:33Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #52779 at sha e7f0495

matanlurey · 2024-05-13T23:26:41Z

Oops, definitely broke OpenGLES. Will revisit tomorrow morning.

jonahwilliams · 2024-05-14T16:38:20Z

impeller/renderer/backend/gles/sampler_gles.cc


 #include "impeller/renderer/backend/gles/sampler_gles.h"

+#include "GLES3/gl3.h"


I think you don't want this include here

jonahwilliams

LGTM

flutter-dashboard · 2024-05-14T17:15:47Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #52779 at sha 459759b

matanlurey · 2024-05-15T01:36:56Z

@chinmaygarde: I'm going to merge this, but comments still welcome after the fact.

…lt. (flutter/engine#52779)

…148428) flutter/engine@bf1c6da...41b86b5 2024-05-15 [email protected] Roll Skia from 475559da107d to b9a304eb05d2 (1 revision) (flutter/engine#52857) 2024-05-15 [email protected] Migrate TextInputSemanticsObject to ARC (flutter/engine#52785) 2024-05-15 [email protected] Roll Fuchsia Linux SDK from NbCi2ETfLHPLLB-JV... to Ftw7GopnudHydGS1y... (flutter/engine#52853) 2024-05-15 [email protected] Roll Dart SDK from 7d9de0c0b231 to f773d45634ed (2 revisions) (flutter/engine#52854) 2024-05-15 [email protected] Roll buildroot (flutter/engine#52826) 2024-05-15 [email protected] Roll Skia from 4a7419d662d5 to 475559da107d (5 revisions) (flutter/engine#52848) 2024-05-15 [email protected] Roll Skia from a9ba7411d4b2 to 4a7419d662d5 (1 revision) (flutter/engine#52844) 2024-05-15 [email protected] Roll Dart SDK from 1eec9de2f9c6 to 7d9de0c0b231 (1 revision) (flutter/engine#52841) 2024-05-15 [email protected] Roll Skia from b3aadd56d187 to a9ba7411d4b2 (1 revision) (flutter/engine#52839) 2024-05-15 [email protected] Roll Skia from c0caf10486ce to b3aadd56d187 (3 revisions) (flutter/engine#52837) 2024-05-15 [email protected] Roll Skia from fad584324d85 to c0caf10486ce (1 revision) (flutter/engine#52835) 2024-05-15 [email protected] Migrate SemanticsObject and FlutterSemanticsScrollView to ARC (flutter/engine#52824) 2024-05-15 [email protected] Roll Dart SDK from 0b77fbab8cf5 to 1eec9de2f9c6 (1 revision) (flutter/engine#52833) 2024-05-15 [email protected] Roll Skia from d0d87c26b489 to fad584324d85 (1 revision) (flutter/engine#52831) 2024-05-15 [email protected] Re-add `MipFilter::kBase`, but keep `kNearest` as the default. (flutter/engine#52779) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from NbCi2ETfLHPL to Ftw7GopnudHy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

matanlurey added 2 commits May 13, 2024 14:33

Re-add kBase, but keep kNearest as the default.

4080af8

Inline VK mip translation.

00eb49d

matanlurey requested review from chinmaygarde and jonahwilliams May 13, 2024 21:51

github-actions bot added the e: impeller label May 13, 2024

jonahwilliams reviewed May 13, 2024

View reviewed changes

jonahwilliams approved these changes May 13, 2024

View reviewed changes

++

e7f0495

flutter-dashboard bot added the will affect goldens label May 13, 2024

Fix GLES rendering.

5cb53a5

matanlurey requested a review from jonahwilliams May 14, 2024 16:33

jonahwilliams reviewed May 14, 2024

View reviewed changes

jonahwilliams approved these changes May 14, 2024

View reviewed changes

++

459759b

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2024

auto-submit bot merged commit f0e4350 into flutter:main May 15, 2024

engine-flutter-autoroll mentioned this pull request May 15, 2024

Roll Flutter Engine from bf1c6da0dd31 to db709391a18a (8 revisions) flutter/flutter#148415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2024

f0e4350f7 Re-add MipFilter::kBase, but keep kNearest as the defau…

9dd7a86

…lt. (flutter/engine#52779)

engine-flutter-autoroll mentioned this pull request May 15, 2024

Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) flutter/flutter#148428

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2024

f0e4350f7 Re-add MipFilter::kBase, but keep kNearest as the defau…

c5ee5cd

…lt. (flutter/engine#52779)

jonahwilliams mentioned this pull request May 31, 2024

[Impeller] dart:ui Images used in shaders result in wrong color sampled due to forced mipmapped sampling on Impeller flutter/flutter#131194

Closed

2 tasks


		#include "impeller/renderer/backend/gles/sampler_gles.h"

		#include "GLES3/gl3.h"

Re-add MipFilter::kBase, but keep kNearest as the default. #52779

Re-add MipFilter::kBase, but keep kNearest as the default. #52779

Uh oh!

Conversation

matanlurey commented May 13, 2024

Uh oh!

jonahwilliams May 13, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams May 14, 2024

Choose a reason for hiding this comment

Uh oh!

matanlurey May 14, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams May 14, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams May 13, 2024

Choose a reason for hiding this comment

Uh oh!

matanlurey May 13, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented May 13, 2024

Uh oh!

matanlurey commented May 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonahwilliams May 14, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented May 14, 2024

Uh oh!

matanlurey commented May 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Re-add `MipFilter::kBase`, but keep `kNearest` as the default. #52779

Re-add `MipFilter::kBase`, but keep `kNearest` as the default. #52779

matanlurey commented May 13, 2024 •

edited

Loading