This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Various documentation improvements #52600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/ui/painting.dart
Outdated
Comment on lines
5376
to
5377
| /// Multiple calls to this method with different arguments (from the same | ||
| /// image) can be batched into a single call to [drawAtlas] to improve |
Contributor
There was a problem hiding this comment.
Not sure I follow this part. The additional color + image blending and transforms can be different per draw, but otherwise all draws share the same filters/alpha.
Contributor
Author
There was a problem hiding this comment.
yeah maybe this isn't worth saying for drawImage. I'll remove it.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2024
Member
|
Reason for revert: Failing to roll to the framework on a snippet analysis failure: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8748612253464522177/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout |
zanderso
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
May 7, 2024
This reverts commit 824d860.
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
May 7, 2024
Reverts: #52600 Initiated by: zanderso Reason for reverting: Failing to roll to the framework on a snippet analysis failure: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8748612253464522177/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout Original PR Author: Hixie Reviewed By: {jonahwilliams} This change reverts the following previous change: No description provided.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 7, 2024
…147926) flutter/engine@150f694...5d94a52 2024-05-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Various documentation improvements (#52600)" (flutter/engine#52607) 2024-05-07 [email protected] Various documentation improvements (flutter/engine#52600) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
May 7, 2024
Contributor
Author
|
reland in #52623 |
Hixie
added a commit
that referenced
this pull request
May 9, 2024
zanderso
added a commit
that referenced
this pull request
May 10, 2024
zanderso
added a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.