[Impeller] fix missing GPU probe. #52580
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Perhaps there is a way to put this in the base swapchain implementations. But I don't suppose we are going to be adding more vulkan swapchain variants any time soon. |
jonahwilliams
added
the
autosubmit
| auto context = transients_->GetContext().lock(); | ||
| if (context) { | ||
| ContextVK::Cast(*context).GetGPUTracer()->MarkFrameEnd(); | ||
| } | ||
|
|
There was a problem hiding this comment.
The code looks good to me. I'm unsure if this is the proper place for it though. There is an assert in MarkFrameEnd, FML_DCHECK(state.pending_buffers == 0u); which sounds appropriate. There is a transaction below here, we don't want to include that in our timing, right?
There was a problem hiding this comment.
Right, I tried not to include the final cmd buffer submission because I don't want to measure anything related to presentation time. In theory it doesn't matter because the probe itself is using bottom of pipe
…147895) flutter/engine@463ff7d...422f92b 2024-05-06 [email protected] Migrate third_party/android_tools to flutter/third_party (flutter/engine#52582) 2024-05-06 [email protected] Roll Skia from a5c042cb4b12 to 869cacf2a3f1 (1 revision) (flutter/engine#52583) 2024-05-06 [email protected] [Impeller] remove unused includes. (flutter/engine#52579) 2024-05-06 [email protected] Roll Skia from da772ace76ff to a5c042cb4b12 (6 revisions) (flutter/engine#52581) 2024-05-06 [email protected] [Impeller] fix missing GPU probe. (flutter/engine#52580) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Fixes flutter/flutter#147723
The test that covers this is the benchmarks in the framework repo. Unfortunately emulators do not support the APIs needed to execute this code in the engine repo.